use Lchown instead of Chown so that symbolic links are not followed#27
Merged
Conversation
Signed-off-by: E. Madison Bray <erik.bray@lri.fr>
caleblloyd
approved these changes
Jun 12, 2020
Collaborator
|
Thank you for the contribution! Yes it does seem that |
Collaborator
|
Published in v0.5 |
Contributor
Author
|
Great, thanks for the quick release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for this very helpful tool--it solves exactly the problem I was having.
However, I noticed that symbolic links within the paths I configured were not being touched up. This is because while
filepath.Walkdoes not follow links,syscall.Chowndoes. This is especially a problem if I have symlinks within my user path to files outside the user path that I might not want changed. UsingLchownensures that symlinks are handled the same as normal files.