Auto-exclude hidden names - #18
Open
slburson wants to merge 1 commit into
Open
Conversation
Also, improve diagnostic infrastructure, and fix a severe performance bug (LibTorch now runs 7x faster).
slburson
commented
Jul 3, 2026
Comment on lines
-302
to
+326
| resect_filter_status filter_status = resect_cursor_filter_status(shaking_context->filtering, cursor); | ||
|
|
||
| bool node_existed = resect_decl_graph_has_node(shaking_context->decl_graph, decl_id); | ||
| if (!node_existed) { | ||
| resect_filter_status filter_status = resect_cursor_filter_status(shaking_context->filtering, cursor); |
Author
There was a problem hiding this comment.
This is the performance fix. In the course of testing the above, I noticed that resect_cursor_filter_status was being called more than once per symbol — and of course it's quite expensive since it's doing a bunch of regex matching. I started to add a cache to it, then noticed there already was one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Claw #31 for explanation.
This PR also fixes a severe performance bug (LibTorch now runs 7x faster — 10 minutes instead of over an hour).