Repository navigation
test(e2e): section keys follow the five-section rail - #63
Open
borght-dev wants to merge 1 commit into
Open
borght-dev wants to merge 1 commit into
borght-dev wants to merge 1 commit into
Conversation
Dispatch took key 2, so Worktrees is 5 and Pull requests is 3. The navigation spec still pressed 4 for Worktrees and failed on master. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
playwright (e2e)job is red on master since the Dispatch stack merged.shell-navigation.spec.tspressed4and expected Worktrees. Dispatch took key 2, so Worktrees is5and Pull requests is3. The app is right and the test was stale. It slipped through because CI only runs on pull requests intomaster, and the section change sat in #56, which targeted another branch.The test now presses
5,2and3, and also checks that2opens Dispatch.How I checked it
bunx playwright test tests/e2e/shell-navigation.spec.tspasses locally, 6 of 6.🤖 Generated with Claude Code