ioctl(fd, TCGETS, ...) = -1 ENOTTY

[ThomasWaldmann]

just noticed while stracing:

ioctl(5, TCGETS, 0x7ffef1435b60)  = -1 ENOTTY (Inappropriate ioctl for device)

this happens for about any file borg create reads.

any idea how to get rid of this?

i thought it might be related to default buffering=-1 of os.fdopen(), but setting it to 0 or 4096 didn't help.

python 3.6.5

[ThomasWaldmann]

    fh = os.open(path, flags_noatime)
    with os.fdopen(fh, 'rb') as fd:
        (read file)

[ThomasWaldmann]

Looks like we do not really need the fd there as we have the fh (and the chunker uses the fh, if valid).

[ThomasWaldmann]

https://github.com/python/cpython/blob/c0ee341b29bd7d978b49272a2c0e2dcfa77404d5/Modules/_io/_iomodule.c#L392

[ThomasWaldmann]

Code to reproduce:

with open('foo', 'rb', buffering=0) as f:
    f.read()

[Dav1dde]

Issue created in Python bug-tracker: https://bugs.python.org/issue34070