Skip to content

install: Enable installing to multi device parents#1911

Draft
ckyrouac wants to merge 1 commit intobootc-dev:mainfrom
ckyrouac:multiple-backing-devices
Draft

install: Enable installing to multi device parents#1911
ckyrouac wants to merge 1 commit intobootc-dev:mainfrom
ckyrouac:multiple-backing-devices

Conversation

@ckyrouac
Copy link
Collaborator

When the root filesystem spans multiple backing devices (e.g., LVM across multiple disks), discover all parent devices and find ESP partitions on each. For bootupd/GRUB, install the bootloader to all devices with an ESP partition, enabling boot from any disk in a multi-disk setup. systemd-boot and zipl only support single-device configurations.

This adds a new integration test validating both single-ESP and dual-ESP multi-device scenarios.

Fixes: #481

Assisted-by: Claude Code (Opus 4.5)

@github-actions github-actions bot added the area/install Issues related to `bootc install` label Jan 14, 2026
@bootc-bot bootc-bot bot requested a review from cgwalters January 14, 2026 19:54
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully enables installing to multi-device parent filesystems, such as LVM spanning multiple disks. It correctly discovers all parent devices and, for bootupd/GRUB, installs the bootloader to all devices with an ESP partition. For bootloaders that only support single-device configurations like systemd-boot and zipl, the implementation correctly defaults to using the first available device. The changes are well-architected, adapting data structures and logic to handle multiple devices. A new, thorough integration test validates both single and dual ESP scenarios. Overall, this is a solid enhancement with good error handling and logging. I have one suggestion to further improve the robustness of ESP detection.

cgwalters
cgwalters previously approved these changes Jan 15, 2026
@ckyrouac ckyrouac force-pushed the multiple-backing-devices branch from f2a175a to f7b1892 Compare January 15, 2026 20:26
@ckyrouac ckyrouac marked this pull request as draft January 15, 2026 20:26
@ckyrouac
Copy link
Collaborator Author

waiting to merge until the patch release goes out

@ckyrouac ckyrouac force-pushed the multiple-backing-devices branch 3 times, most recently from 77b65cb to d03c6fa Compare January 16, 2026 17:31
@HuijingHei
Copy link
Contributor

Maybe this PR could help to consider #1916 ? @ckyrouac

@cgwalters cgwalters force-pushed the multiple-backing-devices branch from d03c6fa to 9b1c313 Compare January 21, 2026 13:08
@ckyrouac ckyrouac force-pushed the multiple-backing-devices branch 2 times, most recently from 6802697 to 081f3b2 Compare January 22, 2026 15:29
@ckyrouac ckyrouac marked this pull request as ready for review January 22, 2026 19:28
@bootc-bot bootc-bot bot requested a review from jeckersb January 22, 2026 19:28
@ckyrouac ckyrouac force-pushed the multiple-backing-devices branch from 081f3b2 to 9d0e284 Compare January 23, 2026 14:53
Signed-off-by: ckyrouac <ckyrouac@redhat.com>
@ckyrouac ckyrouac force-pushed the multiple-backing-devices branch from 9d0e284 to 4ccc192 Compare March 11, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/install Issues related to `bootc install`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bootc install to-existing-root fails with multiple backing devices

3 participants