This repository was archived by the owner on Feb 27, 2018. It is now read-only.
Print only base binary name in usage string (win)#358
Merged
gmlewis merged 1 commit intoboot2docker:masterfrom Mar 27, 2015
ahmetb:usage-string-short
Merged
Print only base binary name in usage string (win)#358gmlewis merged 1 commit intoboot2docker:masterfrom ahmetb:usage-string-short
gmlewis merged 1 commit intoboot2docker:masterfrom
ahmetb:usage-string-short
Conversation
When `boot2docker` is called from msys bash shell, usage string prints the full path of the binary (e.g. `c:\program file\boot2docker for windows\boot2docker.exe`) in the short usage string. This change fixes that without breaking the behavior on unix systems or cmd.exe/powershell on windows which already print the short binary name Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
Contributor
|
LGTM cc @gmlewis @Moghedrin |
Contributor
|
LGTM |
gmlewis
added a commit
that referenced
this pull request
Mar 27, 2015
Print only base binary name in usage string (win)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
boot2dockeris called from msys bash shell, usage string prints thefull path of the binary (e.g.
c:\program file\boot2docker for windows\boot2docker.exe)in the short usage string.
This change fixes that without breaking the behavior on unix systems or
cmd.exe/powershell on windows which already print the short binary name
Before/after
Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
cc: @tianon