refactor: adopt bomly-sdk v0.13.0's package split - #7
Merged
Merged
Conversation
v0.13.0 dissolves the SDK root package into model (the domain types), plugin (the component contract), runtime (the managed-plugin transport), and httpkit (outbound HTTP policy). Every identifier keeps its name; only the package that owns it changes, so this is a mechanical move. This module's own package is named plugin, so the SDK's contract package is imported as sdkplugin. Applied with the SDK's migration tooling, which resolves each reference by type-checking against the old layout rather than by pattern-matching text. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bomly-sdk v0.13.0
dissolves the SDK root package into four packages, split by the question each
answers. Every identifier keeps its name; only the package that owns it moves:
sdk.)model.Detector/Matcher/Auditor/Analyzer,Base*,*Descriptor,*Request/*Result,Module,HostContext,ConfigSchemaFor,PluginKind*plugin.ServeModule,Serve*,Client,HandshakeConfig,ClientPluginMap,DecodePluginConfigFromEnvruntime.HTTPClientProvider,HTTPClientConfig,NewHTTPClientProvider*,EnvHTTP*httpkit.ClientProvider,httpkit.ClientConfig,httpkit.NewClientProvider*,httpkit.EnvHTTP*The wire protocol is unchanged, so a binary built from this branch speaks the
same
bomly.plugin.v1as before and interoperates with an unmigrated host.This module's own package is named plugin, so the SDK's contract package is
imported as sdkplugin.
How it was done
Applied with the migration tooling written alongside the SDK split: it
type-checks each package against the old single-package layout to learn what
every
sdk.Xreference actually is, then rewrites it to the package that ownsit now. That is why aliases, shadowed names, and build-tagged files are handled
rather than guessed at.
Verification
go build ./...,go vet ./..., andgo test ./...pass, plusgo vetundereach build tag this module uses.
🤖 Generated with Claude Code