Skip to content

fix(storybook): unbreak the storybook build check - #49

Merged
A-x6 merged 2 commits into
devfrom
storybook-build
Jul 31, 2026
Merged

A-x6 merged 2 commits into
devfrom
storybook-build

Conversation

@A-x6

@A-x6 A-x6 commented Jul 31, 2026

Copy link
Copy Markdown

Issue for this PR

Closes #48

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

The storybook build check fails on dev and every open PR with Could not detect Solid version: solid-js is not installed. The framework detects the Solid major version through storybook's package-manager helpers, whose fallback reads the raw dependency specifier and coerces it as semver:

// storybook getVersionSafe
let version = await packageManager.getInstalledVersion(packageName);
return version || (version = packageManager.getAllDependencies()[packageName] ?? ""),
  coerce(version, { includePrerelease: !0 })?.toString();

packages/storybook/package.json declared "solid-js": "catalog:", and coerce("catalog:") returns nothing, so detection throws before the build starts. There is no framework option to bypass it, so this pins the specifier to the concrete catalog version 1.9.10 (same resolved version, bun install reports no changes, and the solid-js@1.9.10 patch still applies).

With detection fixed the build then dies with FATAL ERROR: Ineffective mark-compacts near heap limit, so the workflow now sets NODE_OPTIONS: --max-old-space-size=6144 for the build step.

Tradeoff: a future solid-js catalog bump must also touch this one specifier; storybook's detection leaves no catalog-compatible alternative.

How did you verify your code works?

Reproduced the exact CI failure locally with bun --cwd packages/storybook build, applied the pin (detection error gone, build proceeds), hit the OOM, and confirmed Storybook build completed successfully with the raised heap.

Screenshots / recordings

CI-only change.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

View with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is enabled.

Summary by CodeRabbit

  • Chores
    • Improved Storybook build reliability by allocating additional memory during builds.
    • Updated the Storybook package’s SolidJS version to ensure consistent builds.

@vercel

vercel Bot commented Jul 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bolt-cli-app Ready Ready Preview Jul 31, 2026 12:17am

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 88204792-7fe0-450a-858e-042e05f868f1

📥 Commits

Reviewing files that changed from the base of the PR and between a07be0b and b1051f0.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • .github/workflows/storybook.yml
  • packages/storybook/package.json

📝 Walkthrough

Walkthrough

Storybook now pins solid-js to version 1.9.10 and increases the Node.js heap limit to 6144 MB for CI builds.

Changes

Storybook build

Layer / File(s) Summary
Solid version declaration
packages/storybook/package.json
Pins the solid-js dev dependency to 1.9.10 instead of the catalog reference.
Build memory configuration
.github/workflows/storybook.yml
Sets NODE_OPTIONS to --max-old-space-size=6144 for the Storybook build.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: brendonovich

Poem

A rabbit hops through Storybook bright,
With Solid pinned just right.
More heap beneath the moonlit sky,
Lets every build go bounding by.
CI carrots wait nearby!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes fixing the Storybook build check, matching the primary changes.
Description check ✅ Passed The description includes the issue, change type, root cause, fixes, verification steps, screenshots note, and completed checklist.
Linked Issues check ✅ Passed The changes satisfy issue #48 by pinning solid-js for version detection and increasing Node heap memory for the build.
Out of Scope Changes check ✅ Passed Both changes directly address the Storybook build failures described in issue #48, with no unrelated modifications identified.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch storybook-build

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.


Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

The following comment was made by an LLM, it may be inaccurate:

@A-x6
A-x6 merged commit abcff88 into dev Jul 31, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

storybook build fails on every PR: Could not detect Solid version

1 participant