fix(storybook): unbreak the storybook build check - #49
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughStorybook now pins ChangesStorybook build
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Comment |
|
The following comment was made by an LLM, it may be inaccurate: |
Issue for this PR
Closes #48
Type of change
What does this PR do?
The
storybook buildcheck fails on dev and every open PR withCould not detect Solid version: solid-js is not installed. The framework detects the Solid major version through storybook's package-manager helpers, whose fallback reads the raw dependency specifier and coerces it as semver:packages/storybook/package.jsondeclared"solid-js": "catalog:", andcoerce("catalog:")returns nothing, so detection throws before the build starts. There is no framework option to bypass it, so this pins the specifier to the concrete catalog version1.9.10(same resolved version,bun installreports no changes, and thesolid-js@1.9.10patch still applies).With detection fixed the build then dies with
FATAL ERROR: Ineffective mark-compacts near heap limit, so the workflow now setsNODE_OPTIONS: --max-old-space-size=6144for the build step.Tradeoff: a future solid-js catalog bump must also touch this one specifier; storybook's detection leaves no catalog-compatible alternative.
How did you verify your code works?
Reproduced the exact CI failure locally with
bun --cwd packages/storybook build, applied the pin (detection error gone, build proceeds), hit the OOM, and confirmedStorybook build completed successfullywith the raised heap.Screenshots / recordings
CI-only change.
Checklist
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.Summary by CodeRabbit