fix(ci): skip desktop updater feed when signing key is unavailable - #41
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 2 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Comment |
|
The following comment was made by an LLM, it may be inaccurate: |
Issue for this PR
Closes #40
Type of change
What does this PR do?
Release run 30585007660 (v2.0.0) failed at its final step:
finalize-latest-json.tssigns desktop update artifacts viabunx @tauri-apps/cli signer sign, and the fork'sTAURI_SIGNING_PRIVATE_KEYsecret is not a valid minisign key (incorrect updater private key password: Missing comment in secret key). That killed the release after npm and Docker had already published, leaving the GitHub release stuck in draft with no version tag pushed.This applies the same partial-release policy the workflow already uses for electron/signing legs: the updater feed skips itself with a workflow warning instead of failing the release.
finalize-latest-yml.tskeeps running unconditionally since electron-updater's latest.yml relies on embedded sha512 checksums, not the Tauri key. The consequence of a skip is only that the desktop app won't discover the version via auto-update; the proper long-term fix (generate a Bolt updater keypair and embed its public key in the desktop updater config) is tracked in #40.How did you verify your code works?
bun build --no-bundle script/publish.tsparses clean and the failure output is preserved in the log via the captured stdout/stderr. The change is a.nothrow()guard around an existing invocation; behavior with a valid key is unchanged.Screenshots / recordings
Not a UI change.
Checklist
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.