Add ref to definedProps#805
Merged
bokuweb merged 1 commit intobokuweb:masterfrom Apr 24, 2024
Merged
Conversation
Owner
|
@jorgezreik Thanks!!!!!!!!!!!! |
Owner
|
@jorgezreik 6.9.16 published 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed solution
Fixes
resizablefield always beingnullin React 18.3.After this React PR for 18.3,
refis included as a normal prop. Because of this, we detectrefas a user-provided prop and break our ref logic. This causes theresizablefield of our Resizable component to always readnull. To fix this, we addrefto our defined props to ensure that we do not consider it a user-provided prop.Tradeoffs
There should be no negative effects from this change.
For all users with React < 18.3, it is impossible to pass
refinpropsas it is removed by React, so this change will not affect them. For all users with React >= 18.3, this will fix the behavior ofrefin their resizable component.Testing Done
Tested accessing the
resizablefield in both React 18.0 and 18.3. Both work!