Repository navigation
core, core/state: fix storage and block import metrics - #3838
Merged
Merged
Conversation
Pull Request ReviewThis PR initializes the state storage-update timer before trie processing, preventing invalid or overflowing timing statistics when processing completes immediately. It also removes duplicate block import duration and throughput metric updates from Sensitive ContentNo sensitive content detected. Security IssuesNo serious security issues detected. Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits. |
joey0612
approved these changes
Oct 8, 2026
flywukong
approved these changes
Oct 8, 2026
will-2012
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialize the storage-update timer before processing trie updates, preventing zero-time durations from overflowing state timing statistics. Report block import duration and throughput only through
ExecuteStats.reportMetrics, so each imported block contributes one sample tochain/insertsandchain/mgasps.Validation:
TestUpdateLeaks,TestIntermediateLeaks, andTestStorageDirtiness.make all, repository lint (includingcmd/keeper), generated-file/module hygiene checks, and forbidden-dependency checks all passed.Tests were limited to the affected logic; the full test suite was not run.