Repository navigation
miner/minerconfig: fix mev default port - #3824
Merged
Merged
Conversation
Pull Request ReviewThis Go/Ethereum miner configuration change backfills default BEP-675 gRPC port, concurrency, and request-timeout values when they are omitted or invalid. It also clarifies the gRPC port comment and adds a unit test verifying defaults are applied while an explicitly configured port is preserved. Sensitive ContentNo sensitive content detected. Security IssuesNo serious security issues detected. Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits. |
flywukong
approved these changes
Sep 15, 2026
joey0612
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix mev default port panic.
Rationale
#3810 pr's fix to avoid panic when without port config.
Example
Changes
Notable changes: