Repository navigation
core/vm: continue after super-instruction fallback - #3622
Merged
Merged
Conversation
MatusKysel
requested review from
allformless and
annielz
and removed request for
allformless
March 26, 2026 08:44
NathanBSC
approved these changes
Mar 31, 2026
allformless
approved these changes
Mar 31, 2026
mliu233
approved these changes
Mar 31, 2026
annielz
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
When a fused opcode falls back to its raw opcode sequence, the interpreter should continue execution exactly as if the unfused opcodes had been stepped normally.
The previous fallback path executed decomposed opcodes outside the main loop. That made control flow continue, but it bypassed main-loop behavior that is consensus- and tooling-relevant:
OnOpcodetracing for fallback-executed opcodesThis change routes fallback through the existing interpreter loop so raw opcodes inherit the same gas, tracing, and PC progression semantics as normal execution.
Implementation
fallback []OpCodequeue in the interpreter loop.