feat: fish autocomplete - #52
Conversation
|
@molisani Love the package! Let me know if you have any suggestions |
|
Ah, thank you very much for this contribution! This looks like all the machinery needed to register an autocomplete command with However, I'm not familiar with how I don't think we would necessarily need that to get this PR merged, as the logic you've written up here is still correct and necessary, but I would want to make sure that we have a through-line for confirming that auto-complete works as expected. |
Signed-off-by: loks0n <22452787+loks0n@users.noreply.github.com>
Signed-off-by: loks0n <22452787+loks0n@users.noreply.github.com>
Signed-off-by: loks0n <22452787+loks0n@users.noreply.github.com>
Ah right! I think it's slightly different. I've gone ahead and created a new file specifically for fish. Let me know if you want to go with an alternative approach. |
|
I've created #58 which changes the approach for handling different shells. It needs further review from my team and there may be some small changes before it gets merged, but I think it would be easier to land your changes on top of #58. I'm currently out-of-office this week but I think once I am back I can prioritize that PR to make way for your feature. |
|
@loks0n I need to apologize for not following up on your pull request in a timely manner and letting it fall through the cracks. I thought that the alternate structure for handling shells from #58 was going to be the future, but it never really shook out that way. I can say that with the recent addition of integrations I am re-exploring the general approach to auto-completions: we should be able to have auto-complete built directly into the apps rather than a separate entrypoint. If everything goes well we can support bomb.sh/tab and all of the shells that it supports already (including |
Adds auto completion for fish shell