fix: allow custom environment variable name for help/version - #185
Open
molisani wants to merge 1 commit into
Open
fix: allow custom environment variable name for help/version#185molisani wants to merge 1 commit into
molisani wants to merge 1 commit into
Conversation
Signed-off-by: Michael Molisani <mmolisani@bloomberg.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Stricli makes uses of two environment variables to control certain behaviors:
STRICLI_SKIP_VERSION_CHECKdisables the version checkSTRICLI_NO_COLORdisables ANSI color codesNow that help text and version checks are their own integrations, there's no reason that these need to be hardcoded. If there's some application "foo" then it can have its own
FOO_SKIP_VERSION_CHECKenvironment variable (for whatever reason).Testing performed
Updated test suite to account for new behavior, ensured code coverage.
Additional context
Right now this change will only allow customizing the ANSI color codes for the help text output. It might make sense to allow customizing
STRICLI_NO_COLORfor the entire application as well, not just the help text. Could be a good follow-up item.