Repository navigation
Add the missing spaces in the reconstruction prompts - #30
Open
taha-yasin-saad wants to merge 1 commit into
Open
taha-yasin-saad wants to merge 1 commit into
taha-yasin-saad wants to merge 1 commit into
Conversation
The prompts told the model "at most40", "under16000", "at most6", "at most80" and "by30; a final24px corner therefore needs0.8px". Add the spaces. No logic changes. Fixes blixvip#3 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V9HzEhhJZTrWxiHmgkm6sK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes #3. The prompt literals in
app/scene_pipeline.py(lines 199 and 234) and theGUIDEconstant inapp/rebuild_author.py(lines 108 and 113) fused words to numbers:at most40,under16000,at most6,at most80,by30; a final24px corner therefore needs0.8px. This adds the spaces. No logic changes.How did you test it?
python -m pytest -q: 104 passed, 2 skipped, 14 failed. The same 14 fail onmain; they callffprobe/ffmpeg, which the test machine doesn't have.cd remotion && npm test(not touched)Checklist
local_boundarylocalhost-and-token check is intactdata/,.venv/, or any reference footageTested on Linux (WSL2, Python 3.12). Made with AI assistance (Claude Code); I reviewed the diff and ran the suite as above.