Open
Conversation
…earch on GPU indexes
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces optional GPU acceleration for Faiss float32 vector indexes, enabling GPU-backed training/index build and GPU-accelerated unfiltered search while keeping CPU compatibility for filtered and advanced operations.
Changes:
- Plumbs a new
UseGPUfield option through indexing, merging, and runtime index loading paths. - Adds a GPU-backed float32 Faiss index wrapper with asynchronous GPU cloning and batched GPU search.
- Updates Faiss index training APIs to a
trainAndAddflow to support GPU sync behavior, and bumpsbleve_index_apito a newer pseudo-version.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| section_faiss_vector_index.go | Threads useGPU into index creation/merge and adjusts training/add ordering for GPU-backed IVF indexes. |
| faiss_vector_posting.go | Passes useGPU into vector index cache load/create for runtime search. |
| faiss_vector_index.go | Updates Faiss IVF/SQ interfaces from train to trainAndAdd with GPU-related semantics. |
| faiss_vector_index_gpu_float32.go | Adds the GPU-backed float32 index wrapper (CPU+GPU, batched GPU search, CPU fallbacks). |
| faiss_vector_index_float32.go | Implements trainAndAdd for the CPU float32 index. |
| faiss_vector_index_bivf.go | Implements trainAndAdd for the binary IVF index. |
| faiss_vector_cache.go | Extends cache load/create to optionally wrap loaded float32 indexes with the GPU wrapper. |
| go.mod | Pins bleve_index_api to a newer pseudo-version via replace. |
| go.sum | Updates module checksums for the bleve_index_api version change. |
Comments suppressed due to low confidence (1)
go.mod:25
- The module is still
require-inggithub.com/blevesearch/bleve_index_api v1.3.9while areplaceforces a newer pseudo-version. If the intent is to pin to that commit, prefer updating therequireversion directly and dropping thereplace(unless you specifically need a local fork or a temporary override), sincereplacedirectives can make dependency management and downstream builds harder to reason about.
github.com/spf13/pflag v1.0.9 // indirect
golang.org/x/sys v0.40.0 // indirect
)
replace github.com/blevesearch/bleve_index_api => github.com/blevesearch/bleve_index_api v1.3.10-0.20260403181255-6dc4a7ba4807
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CascadingRadium
approved these changes
Apr 9, 2026
Member
|
hey @capemox, please resolve merge conflicts due to the |
abhinavdangeti
approved these changes
Apr 13, 2026
CascadingRadium
approved these changes
Apr 14, 2026
Member
|
@capemox Let's merge this to create a separate commit after the upstream change has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new GPU float32 vector index type which supports training and search on GPU indexes