Graceful cloudcheck error handling + SSL verify passthrough#3239
Merged
Conversation
Forward bbot's ssl_verify_infrastructure setting to cloudcheck's new verify_ssl constructor param, and stop cloudcheck signature-fetch failures from crashing scans. - helper.py: CloudCheck(verify_ssl=ssl_verify_infrastructure) - cloudcheck module setup(): catch CloudCheckError on the warm-up lookup; warn and continue with cloud detection degraded instead of aborting the scan - cli.py: catch CloudCheckError on the pre-scan cloud-domain check - bump cloudcheck 10.0.0 -> 11.1.0 (verify_ssl support) and baddns to 2.4.1; lock reconciled to pyproject pins (also moves ruff to the already-pinned 0.15.18) Closes #3226
Contributor
📊 Performance Benchmark Report
📈 Detailed Results (All Benchmarks)
🎯 Performance Summary+ 2 improvements 🚀
! 1 regression ⚠️
28 unchanged ✅🔍 Significant Changes (>10%)
🐍 Python Version 3.11.15 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3239 +/- ##
=====================================
- Coverage 90% 90% -0%
=====================================
Files 453 453
Lines 46304 46314 +10
=====================================
+ Hits 41411 41413 +2
- Misses 4893 4901 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ausmaster
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3226 — cloudcheck signature-fetch failures (notably SSL verification issues behind corporate proxies) were crashing scans at
cli.py:237. This forwards bbot's SSL setting to cloudcheck and makes the remaining failure paths non-fatal.Changes
core/helpers/helper.py): constructCloudCheck(verify_ssl=...)fromssl_verify_infrastructure, mirroring howasn.pywires the same setting into asndb. Requires the newverify_sslkwarg, so the dependency is bumped tocloudcheck>=11.1.0,<12.setup()(modules/internal/cloudcheck.py): the warm-up lookup now catchesCloudCheckError, warns, and continues. Bucket regexes (loaded from the cloudcheck package) and per-event lookups (already guarded) keep working, so cloud detection degrades instead of failing setup.cli.py): the interactive "is this target a cloud domain?" lookup catchesCloudCheckErrorand warns instead of aborting the scan.cloudcheck10.0.0 → 11.1.0,baddns→ 2.4.1;uv.lockreconciled to the pyproject pins (this also movesruffto the already-pinned0.15.18).Notes on the three requirements in #3226
~/.cache/cloudcheck/cloud_providers_v3.jsonfor 24h without touching the network. The only uncovered sliver is a >24h-stale cache where the refresh then also fails (i.e. the network is genuinely down) — that now degrades gracefully via Two new modules, bugfixes and optimizations #3 rather than crashing. No bundled copy is shipped (the signature JSON is ~2.3 MB and isn't part of the package).setup()andcli.py:237are wrapped, scan continues with a warning.Catches the specific
CloudCheckErrorrather than a broadexcept.