Skip to content

Restore description in VIRTUAL_HOST event display#3224

Merged
liquidsec merged 1 commit into
devfrom
virtualhost-event-display
Jun 23, 2026
Merged

Restore description in VIRTUAL_HOST event display#3224
liquidsec merged 1 commit into
devfrom
virtualhost-event-display

Conversation

@liquidsec

Copy link
Copy Markdown
Collaborator

Summary

When the VIRTUAL_HOST event class was registered in base.py (commit 1f3adf1), _pretty_string and _data_human were written to only show the virtual_host name. Previously, without a dedicated class, the event fell through to the default _data_human which JSON-serialized the full dict -- including the rich description built by _build_description().

Before:

secret-admin.example.com (https://example.com/)

After:

secret-admin.example.com (https://example.com/) Discovery Technique: [SAN certificate], Discovered Content: [Status Code: 200] [Title: Admin Panel] [Size: 4821 bytes] [IP: 93.184.216.34] [Access: externally accessible]

When the VIRTUAL_HOST event class was registered in base.py,
_pretty_string and _data_human only included the virtual_host
name, dropping the rich description that was previously visible
when the event fell through to default JSON serialization.
@liquidsec liquidsec added the quick This is a small and/or trivial change label Jun 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Performance Benchmark Report

⚠️ No current benchmark data available

This might be because:

  • Benchmarks failed to run
  • No benchmark tests found
  • Dependencies missing

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 90%. Comparing base (ef65b09) to head (4330326).

Files with missing lines Patch % Lines
bbot/core/event/base.py 13% 7 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #3224   +/-   ##
=====================================
+ Coverage     90%     90%   +1%     
=====================================
  Files        453     453           
  Lines      46101   46105    +4     
=====================================
+ Hits       41211   41215    +4     
  Misses      4890    4890           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ausmaster ausmaster self-requested a review June 23, 2026 19:36
@ausmaster ausmaster added this to the BBOT 3.0 - blazed_elijah milestone Jun 23, 2026
@liquidsec liquidsec merged commit 222c3d3 into dev Jun 23, 2026
24 of 25 checks passed
@liquidsec liquidsec deleted the virtualhost-event-display branch June 23, 2026 19:47
@liquidsec liquidsec mentioned this pull request Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

quick This is a small and/or trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants