Restore description in VIRTUAL_HOST event display#3224
Merged
Conversation
When the VIRTUAL_HOST event class was registered in base.py, _pretty_string and _data_human only included the virtual_host name, dropping the rich description that was previously visible when the event fell through to default JSON serialization.
Contributor
🚀 Performance Benchmark Report
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3224 +/- ##
=====================================
+ Coverage 90% 90% +1%
=====================================
Files 453 453
Lines 46101 46105 +4
=====================================
+ Hits 41211 41215 +4
Misses 4890 4890 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ausmaster
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the
VIRTUAL_HOSTevent class was registered inbase.py(commit 1f3adf1),_pretty_stringand_data_humanwere written to only show thevirtual_hostname. Previously, without a dedicated class, the event fell through to the default_data_humanwhich JSON-serialized the full dict -- including the rich description built by_build_description().Before:
After: