Harden pickle unpickler in webbrute_shortnames#3200
Merged
Conversation
Restrict CustomUnpickler.find_class to only allow MinimalWordPredictor instead of falling through to the default find_class, which permits arbitrary class instantiation.
Contributor
🚀 Performance Benchmark Report
|
ausmaster
approved these changes
Jun 17, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3200 +/- ##
=====================================
- Coverage 90% 90% -0%
=====================================
Files 453 453
Lines 46024 46026 +2
=====================================
- Hits 41154 41147 -7
- Misses 4870 4879 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CustomUnpickler.find_classinwebbrute_shortnamesfalls through tosuper().find_class()for any class other thanMinimalWordPredictor, allowing arbitrary class instantiation from a malicious pickle payload (supply-chain risk if the upstream model files are compromised)pickle.UnpicklingErrorinstead of falling through