Skip to content

Fix dnscaa crash on unrecognized CAA properties#3193

Merged
liquidsec merged 1 commit into
devfrom
dnscaa-unknown-property
Jun 16, 2026
Merged

Fix dnscaa crash on unrecognized CAA properties#3193
liquidsec merged 1 commit into
devfrom
dnscaa-unknown-property

Conversation

@liquidsec

Copy link
Copy Markdown
Collaborator

Summary

  • Hickory-dns wraps unrecognized CAA property tags (e.g. contactemail, contactphone) as {"Unknown": "name"} instead of a plain string, causing 'dict' object has no attribute 'lower' in handle_event
  • Unwrap the Unknown dict for both tag and value fields
  • Extract emails from contactemail records (RFC 8657)
  • Unknown properties with no handler are silently skipped

Closes #3191

@liquidsec liquidsec marked this pull request as ready for review June 16, 2026 02:57
@liquidsec liquidsec requested a review from ausmaster June 16, 2026 02:57
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Performance Benchmark Report

⚠️ No current benchmark data available

This might be because:

  • Benchmarks failed to run
  • No benchmark tests found
  • Dependencies missing

@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90%. Comparing base (c07e3e7) to head (455178a).
⚠️ Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
bbot/modules/dnscaa.py 82% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #3193   +/-   ##
=====================================
- Coverage     90%     90%   -0%     
=====================================
  Files        449     449           
  Lines      44389   44405   +16     
=====================================
+ Hits       39716   39727   +11     
- Misses      4673    4678    +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liquidsec liquidsec merged commit 14cb8c0 into dev Jun 16, 2026
14 of 16 checks passed
This was referenced Jun 16, 2026
@ausmaster ausmaster deleted the dnscaa-unknown-property branch June 30, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants