Fix -lp scanning arbitrary directories when -p is also specified#3192
Merged
Conversation
PresetPath.find() adds the parent directory of any resolved preset to the search path list, which is correct for include resolution. But all_presets (used by -lp) was iterating the same list, causing it to rglob every .yml file under those incidentally-added directories. On a typical Linux system this means hundreds of Ansible/CI yaml files in $HOME produce warning spam. Add a listable flag to add_path() so only the two canonical preset directories (built-in and ~/.bbot/presets) are enumerated by -lp.
Collaborator
Author
|
@ausmaster can you validate |
Contributor
🚀 Performance Benchmark Report
|
ausmaster
approved these changes
Jun 16, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3192 +/- ##
=====================================
- Coverage 90% 90% -0%
=====================================
Files 449 449
Lines 44389 44435 +46
=====================================
+ Hits 39716 39757 +41
- Misses 4673 4678 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-ploads a preset from an arbitrary path (e.g.~/my_preset.yml),PresetPath.find()adds the parent directory to the search path list for include resolution.all_presets(used by-lp) was iterating that same list with rglob, causing it to try parsing every.ymlfile under the parent directory (e.g. all of$HOME).listableflag toadd_path()so only the two canonical preset directories (built-inbbot/presets/and~/.bbot/presets/) are enumerated by-lp. Paths added byfind()remain searchable for include resolution but are excluded from enumeration.