Skip to content

Verify SSL for infrastructure by default (but not target traffic)#3186

Merged
liquidsec merged 2 commits into
devfrom
ssl-verify-split
Jun 15, 2026
Merged

Verify SSL for infrastructure by default (but not target traffic)#3186
liquidsec merged 2 commits into
devfrom
ssl-verify-split

Conversation

@liquidsec

Copy link
Copy Markdown
Collaborator

Summary

  • Replaces the single ssl_verify config option with two explicit settings:
    • ssl_verify_target (default false) -- for target-directed traffic (probes, crawls, etc.)
    • ssl_verify_infrastructure (default true) -- for non-target traffic (API calls, wordlist downloads, interactsh, ASNDB, etc.)
  • request() accepts a per-call ssl_verify override kwarg; infrastructure callers (api_request, download, interactsh, ASNDB) default to the infrastructure setting
  • requests library patching (used by ansible dep installation) now keys off ssl_verify_infrastructure

@liquidsec liquidsec requested a review from ausmaster June 15, 2026 17:52
@liquidsec liquidsec mentioned this pull request Jun 15, 2026
28 tasks
@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

🚀 Performance Benchmark Report

⚠️ No current benchmark data available

This might be because:

  • Benchmarks failed to run
  • No benchmark tests found
  • Dependencies missing

Replace the single `ssl_verify` config with two explicit options:
- `ssl_verify_target` (default false) for scan target traffic
- `ssl_verify_infrastructure` (default true) for APIs, downloads, interactsh, ASNDB, etc.
@ausmaster ausmaster self-requested a review June 15, 2026 21:41
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90%. Comparing base (d325985) to head (4c791d1).
⚠️ Report is 12 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #3186   +/-   ##
=====================================
- Coverage     90%     90%   -0%     
=====================================
  Files        449     449           
  Lines      43950   43963   +13     
=====================================
- Hits       39291   39289    -2     
- Misses      4659    4674   +15     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liquidsec liquidsec merged commit 536241c into dev Jun 15, 2026
14 of 16 checks passed
@liquidsec liquidsec deleted the ssl-verify-split branch June 15, 2026 22:24
@ausmaster ausmaster added this to the BBOT 3.0 - blazed_elijah milestone Jun 15, 2026
@liquidsec liquidsec mentioned this pull request Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants