Fix CLA check failing for org member commits on external PRs#3167
Closed
aconite33 wants to merge 1 commit into
Closed
Fix CLA check failing for org member commits on external PRs#3167aconite33 wants to merge 1 commit into
aconite33 wants to merge 1 commit into
Conversation
The pre-check step correctly identifies org members and bots as exempt, but when the CLA Assistant step runs (because at least one external committer exists), it re-evaluates all committers against a hardcoded allowlist that only includes bot accounts. This causes org members like liquidsec to be flagged as unsigned when they merge or commit to a PR from an external contributor. Fix by collecting exempt logins during the pre-check loop and appending them to the CLA Assistant's dynamic allowlist. Also changes break to continue so all committers are checked instead of stopping at the first non-exempt one.
Contributor
Author
|
Superseded — centralizing the CLA workflow as a reusable workflow in blacklanternsecurity/.github instead (PR blacklanternsecurity/.github#1). Will open a new PR against bbot with a thin caller. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3167 +/- ##
=====================================
+ Coverage 91% 91% +1%
=====================================
Files 448 448
Lines 42654 42654
=====================================
+ Hits 38397 38402 +5
+ Misses 4257 4252 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
liquidsec) as unsigned when they commit to a PR opened by an external contributorallowlistparameterbreaktocontinueso all committers are checked instead of stopping at the first non-exempt oneContext
Observed on PR #3144 —
liquidsecmergeddevinto the branch, adding his commits. The CLA bot then flagged him as unsigned despite being a BLS org member, because the CLA Assistant step's allowlist only containeddependabot[bot],github-actions[bot],renovate[bot].Note: The same bug exists in other BLS repos that copied this workflow (e.g.
baddns,blockbuster). The master template inblacklanternsecurity/.githubuses a simpler author-only check that avoids this, but doesn't cover all committers. Those repos may want the same fix.Test plan
liquidsecshould now be allowlisted and onlythunderstornXshould be evaluated for CLA signature