Upgrade baddns to 2.4, badsecrets to 1.1

bbot/modules/baddns.py

@@ -60,7 +60,7 @@ class Config(BaseModuleConfig):
         )
 
     module_threads = 8
-    deps_pip = ["baddns~=2.3.0"]
+    deps_pip = ["baddns~=2.4.0"]
 
     def select_modules(self):
         selected_submodules = []

bbot/modules/baddns_direct.py

@@ -22,7 +22,7 @@ class Config(BaseModuleConfig):
         )
 
     module_threads = 8
-    deps_pip = ["baddns~=2.3.0"]
+    deps_pip = ["baddns~=2.4.0"]
 
     scope_distance_modifier = 1
 

bbot/modules/baddns_zone.py

@@ -22,7 +22,7 @@ class Config(BaseModuleConfig):
         )
 
     module_threads = 8
-    deps_pip = ["baddns~=2.3.0"]
+    deps_pip = ["baddns~=2.4.0"]
 
     def set_modules(self):
         self.enabled_submodules = ["NSEC", "zonetransfer"]

bbot/modules/badsecrets.py

@@ -19,7 +19,7 @@ class badsecrets(BaseModule):
     class Config(BaseModuleConfig):
         custom_secrets: Optional[str] = Field(None, description="Include custom secrets loaded from a local file")
 
-    deps_pip = ["badsecrets~=1.0.0"]
+    deps_pip = ["badsecrets~=1.1.0"]
 
     async def setup(self):
         self.custom_secrets = None

bbot/test/test_step_2/module_tests/test_module_badsecrets.py

@@ -177,10 +177,10 @@ def check(self, module_test, events):
             for e in events
         ), "Vulnerable JWT SecretFound finding was not emitted"
 
-        # Safe JWT (IdentifyOnly) should NOT produce any FINDING
-        assert not any(e.type == "FINDING" and self.safe_jwt in e.data["description"] for e in events), (
-            "JWT IdentifyOnly finding should have been suppressed"
-        )
+        # Safe JWT should NOT produce a badsecrets FINDING
+        assert not any(
+            e.type == "FINDING" and e.module == "badsecrets" and self.safe_jwt in e.data["description"] for e in events
+        ), "JWT IdentifyOnly finding should have been suppressed"
 
 
 class TestBadSecrets_customsecrets(TestBadSecrets):

pyproject.toml

@@ -37,7 +37,7 @@ dependencies = [
     "mmh3>=4.1,<6.0",
     "xxhash>=3.5.0,<4",
     "setproctitle>=1.3.3,<2",
-    "yara-python==4.5.2",
+    "yara-python>=4.5.4,<5",
     "pyzmq>=26.0.3,<28.0.0",
     "puremagic>=1.28,<2",
     "pydantic>=2.12.2,<3",
@@ -79,7 +79,7 @@ dev = [
     "fastapi>=0.115.5,<0.137.0",
     "pytest-httpx>=0.35",
     "pytest-benchmark>=4,<6",
-    "baddns~=2.3.0",
+    "baddns~=2.4.0",
     "ruff==0.15.16",
     "maturin>=1.4,<2",
 ]