Skip to content

Use asndb verify=False, respect global ssl_verify config#2995

Merged
liquidsec merged 1 commit into
3.0from
asndb-no-verify
Mar 27, 2026
Merged

Use asndb verify=False, respect global ssl_verify config#2995
liquidsec merged 1 commit into
3.0from
asndb-no-verify

Conversation

@liquidsec

Copy link
Copy Markdown
Collaborator

Summary

  • Bump asndb dependency to >=1.0.4 (adds verify kwarg)
  • Pass verify=False to ASNDB() in both call sites (ASNHelper and ASN target expansion)
  • Plumb the global web.ssl_verify config through so both paths respect it

Closes #2988

@github-actions

Copy link
Copy Markdown
Contributor

📊 Performance Benchmark Report

Comparing 3.0 (baseline) vs asndb-no-verify (current)

📈 Detailed Results (All Benchmarks)

📋 Complete results for all benchmarks - includes both significant and insignificant changes

🧪 Test Name 📏 Base 📏 Current 📈 Change 🎯 Status
Bloom Filter Dns Mutation Tracking Performance 4.17ms 4.19ms +0.4%
Bloom Filter Large Scale Dns Brute Force 17.07ms 17.22ms +0.9%
Large Closest Match Lookup 355.47ms 354.65ms -0.2%
Realistic Closest Match Workload 188.53ms 190.66ms +1.1%
Event Memory Medium Scan 1776 B/event 1776 B/event +0.0%
Event Memory Large Scan 1760 B/event 1760 B/event +0.0%
Event Validation Full Scan Startup Small Batch 401.22ms 400.66ms -0.1%
Event Validation Full Scan Startup Large Batch 574.93ms 571.31ms -0.6%
Make Event Autodetection Small 30.96ms 30.74ms -0.7%
Make Event Autodetection Large 313.07ms 312.36ms -0.2%
Make Event Explicit Types 13.82ms 13.76ms -0.4%
Excavate Single Thread Small 3.930s 3.971s +1.0%
Excavate Single Thread Large 9.383s 9.373s -0.1%
Excavate Parallel Tasks Small 4.116s 4.062s -1.3%
Excavate Parallel Tasks Large 7.186s 7.139s -0.7%
Is Ip Performance 3.19ms 3.17ms -0.6%
Make Ip Type Performance 11.54ms 11.50ms -0.4%
Mixed Ip Operations 4.47ms 4.52ms +1.0%
Typical Queue Shuffle 61.03µs 63.11µs +3.4%
Priority Queue Shuffle 695.11µs 706.86µs +1.7%

🎯 Performance Summary

No significant performance changes detected (all changes <10%)


🐍 Python Version 3.11.15

@codecov

codecov Bot commented Mar 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91%. Comparing base (007424f) to head (29be8cd).
⚠️ Report is 2 commits behind head on 3.0.

Additional details and impacted files
@@          Coverage Diff          @@
##             3.0   #2995   +/-   ##
=====================================
+ Coverage     91%     91%   +1%     
=====================================
  Files        436     436           
  Lines      37070   37072    +2     
=====================================
+ Hits       33673   33690   +17     
+ Misses      3397    3382   -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liquidsec
liquidsec merged commit 8b02acb into 3.0 Mar 27, 2026
16 checks passed
@liquidsec
liquidsec deleted the asndb-no-verify branch March 27, 2026 22:23
@liquidsec liquidsec mentioned this pull request Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants