Fix BBOTTarget pickle support for engine subprocess#2983
Merged
Conversation
TheTechromancer
approved these changes
Mar 23, 2026
Contributor
📊 Performance Benchmark Report
📈 Detailed Results (All Benchmarks)
🎯 Performance Summary✅ No significant performance changes detected (all changes <10%) 🐍 Python Version 3.11.15 |
aconite33
added a commit
that referenced
this pull request
Mar 23, 2026
Remove our __getstate__/__setstate__ from BaseTarget; the upstream fix-target-pickle branch handles this more cleanly (explicit state, direct acl_mode reading, ScanBlacklist override, and a test). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
aconite33
added a commit
that referenced
this pull request
Mar 23, 2026
Remove our __getstate__/__setstate__ from BaseTarget; the upstream fix-target-pickle branch handles this more cleanly (explicit state, direct acl_mode reading, ScanBlacklist override, and a test).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.0 #2983 +/- ##
=====================================
+ Coverage 91% 91% +1%
=====================================
Files 436 436
Lines 36892 36918 +26
=====================================
+ Hits 33516 33546 +30
+ Misses 3376 3372 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BBOTTargetcontains aRadixTarget(Rust/C extension) which can't be pickled. This breaks the HTTP engine subprocess spawn at runtime withcannot pickle 'builtins.PyRadixTarget' object.__getstate__/__setstate__toBaseTargetandScanBlacklistso the radix tree is reconstructed fromevent_seedsafter deserialization.BBOT_TESTING=Trueruns the engine in-process (same event loop), bypassing the pickle path entirely.test_target_pickleto cover pickle round-trips.