Skip to content

Fix lightfuzz deserialization Error Resolution false positives#2944

Merged
TheTechromancer merged 1 commit into
3.0from
lightfuzz-deserialization-fp-fix
Mar 5, 2026
Merged

Fix lightfuzz deserialization Error Resolution false positives#2944
TheTechromancer merged 1 commit into
3.0from
lightfuzz-deserialization-fp-fix

Conversation

@liquidsec

Copy link
Copy Markdown
Collaborator

Transient 500 errors were sometimes causing false positives with the lightfuzz serialization submodule. Fix was to add confirmation step, and also a final last resort which looks at the completely ridiculous outcome of having multiple language families all report deserialization, which is not possible. A bit of a hack, but an extremely effective proxy for catching false positives.

@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

📊 Performance Benchmark Report

Comparing 3.0 (baseline) vs lightfuzz-deserialization-fp-fix (current)

📈 Detailed Results (All Benchmarks)

📋 Complete results for all benchmarks - includes both significant and insignificant changes

🧪 Test Name 📏 Base 📏 Current 📈 Change 🎯 Status
Bloom Filter Dns Mutation Tracking Performance 4.30ms 4.28ms -0.5%
Bloom Filter Large Scale Dns Brute Force 17.81ms 17.84ms +0.2%
Large Closest Match Lookup 361.41ms 360.90ms -0.1%
Realistic Closest Match Workload 197.36ms 195.18ms -1.1%
Event Validation Full Scan Startup Small Batch 496.37ms 499.90ms +0.7%
Event Validation Full Scan Startup Large Batch 771.60ms 765.49ms -0.8%
Make Event Autodetection Small 31.35ms 31.17ms -0.6%
Make Event Autodetection Large 318.04ms 315.16ms -0.9%
Make Event Explicit Types 14.04ms 13.86ms -1.3%
Excavate Single Thread Small 4.097s 4.083s -0.3%
Excavate Single Thread Large 9.943s 9.922s -0.2%
Excavate Parallel Tasks Small 4.262s 4.246s -0.4%
Excavate Parallel Tasks Large 7.386s 7.361s -0.3%
Is Ip Performance 3.21ms 3.20ms -0.5%
Make Ip Type Performance 11.45ms 11.35ms -0.9%
Mixed Ip Operations 4.49ms 4.52ms +0.7%
Typical Queue Shuffle 64.16µs 63.15µs -1.6%
Priority Queue Shuffle 742.50µs 703.35µs -5.3%

🎯 Performance Summary

No significant performance changes detected (all changes <10%)


🐍 Python Version 3.11.14

@codecov

codecov Bot commented Mar 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 92%. Comparing base (f6ae3a1) to head (ab1a6ed).
⚠️ Report is 21 commits behind head on 3.0.

Files with missing lines Patch % Lines
bbot/modules/lightfuzz/submodules/serial.py 80% 6 Missing ⚠️
.../test_step_2/module_tests/test_module_lightfuzz.py 90% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             3.0   #2944   +/-   ##
=====================================
+ Coverage     92%     92%   +1%     
=====================================
  Files        436     436           
  Lines      35640   35692   +52     
=====================================
+ Hits       32506   32576   +70     
+ Misses      3134    3116   -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheTechromancer TheTechromancer merged commit 85e8e42 into 3.0 Mar 5, 2026
14 of 16 checks passed
@liquidsec liquidsec mentioned this pull request Jun 9, 2026
@liquidsec liquidsec deleted the lightfuzz-deserialization-fp-fix branch June 10, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants