Skip to content

Fix double-parsing of targets in BBOTTarget init#2940

Merged
TheTechromancer merged 2 commits into
3.0from
fix-target-double-parsing
Mar 2, 2026
Merged

Fix double-parsing of targets in BBOTTarget init#2940
TheTechromancer merged 2 commits into
3.0from
fix-target-double-parsing

Conversation

@liquidsec

Copy link
Copy Markdown
Collaborator

When seeds aren't explicitly provided, BBOTTarget.init auto-populates them from the target. Previously it used self.target.inputs which returns raw strings, causing every target to go through EventSeed() parsing twice, once for ScanTarget and again for ScanSeeds.

@github-actions

github-actions Bot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

📊 Performance Benchmark Report

Comparing 3.0 (baseline) vs fix-target-double-parsing (current)

📈 Detailed Results (All Benchmarks)

📋 Complete results for all benchmarks - includes both significant and insignificant changes

🧪 Test Name 📏 Base 📏 Current 📈 Change 🎯 Status
Bloom Filter Dns Mutation Tracking Performance 4.22ms 4.20ms -0.4%
Bloom Filter Large Scale Dns Brute Force 17.98ms 17.68ms -1.6%
Large Closest Match Lookup 361.44ms 349.03ms -3.4%
Realistic Closest Match Workload 193.43ms 192.21ms -0.6%
Event Validation Full Scan Startup Small Batch 513.65ms 490.55ms -4.5%
Event Validation Full Scan Startup Large Batch 931.74ms 763.95ms -18.0% 🟢🟢 🚀
Make Event Autodetection Small 31.55ms 31.26ms -0.9%
Make Event Autodetection Large 318.89ms 323.62ms +1.5%
Make Event Explicit Types 14.21ms 14.24ms +0.2%
Excavate Single Thread Small 4.161s 4.227s +1.6%
Excavate Single Thread Large 10.227s 10.031s -1.9%
Excavate Parallel Tasks Small 4.403s 4.403s +0.0%
Excavate Parallel Tasks Large 7.433s 7.580s +2.0%
Is Ip Performance 3.18ms 3.19ms +0.3%
Make Ip Type Performance 11.53ms 11.54ms +0.1%
Mixed Ip Operations 4.45ms 4.49ms +0.9%
Typical Queue Shuffle 61.85µs 62.85µs +1.6%
Priority Queue Shuffle 710.75µs 706.77µs -0.6%

🎯 Performance Summary

+ 1 improvement 🚀
  17 unchanged ✅

🔍 Significant Changes (>10%)

  • Event Validation Full Scan Startup Large Batch: 18.0% 🚀 faster

🐍 Python Version 3.11.14

@codecov

codecov Bot commented Mar 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92%. Comparing base (610c3f4) to head (0da987c).
⚠️ Report is 3 commits behind head on 3.0.

Additional details and impacted files
@@          Coverage Diff          @@
##             3.0   #2940   +/-   ##
=====================================
+ Coverage     92%     92%   +1%     
=====================================
  Files        434     434           
  Lines      35515   35530   +15     
=====================================
+ Hits       32392   32419   +27     
+ Misses      3123    3111   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheTechromancer TheTechromancer merged commit cc18e37 into 3.0 Mar 2, 2026
15 of 16 checks passed
@liquidsec liquidsec mentioned this pull request Jun 9, 2026
@liquidsec liquidsec deleted the fix-target-double-parsing branch June 10, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants