Fix double-parsing of targets in BBOTTarget init#2940
Merged
Conversation
Contributor
📊 Performance Benchmark Report
📈 Detailed Results (All Benchmarks)
🎯 Performance Summary+ 1 improvement 🚀
17 unchanged ✅🔍 Significant Changes (>10%)
🐍 Python Version 3.11.14 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.0 #2940 +/- ##
=====================================
+ Coverage 92% 92% +1%
=====================================
Files 434 434
Lines 35515 35530 +15
=====================================
+ Hits 32392 32419 +27
+ Misses 3123 3111 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheTechromancer
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When seeds aren't explicitly provided, BBOTTarget.init auto-populates them from the target. Previously it used self.target.inputs which returns raw strings, causing every target to go through EventSeed() parsing twice, once for ScanTarget and again for ScanSeeds.