Fix omitted event types leaking to console output

[liquidsec]

Summary

• HTTP_RESPONSE, URL_UNVERIFIED, and DNS_NAME_UNRESOLVED were showing up in console output despite being in omit_event_types

Root Cause

In 7b271f33b ("ruffed"), the always_emit check in BaseOutputModule._event_precheck() was moved from inside the _omit block (where it was an elif, only applying to already-omitted events) to before it as a standalone short-circuit. This changed the semantics: any event with always_emit=True (i.e. events with affiliate/seed tags, or no host) now bypassed the _omit filter entirely, causing omitted event types to print to console.

The always_emit check is unnecessary in the output precheck since ScanEgress already handles it by preventing always_emit events from being marked _internal.

[liquidsec]

@TheTechromancer this seems correct but need your sanity check

[github-actions]

📊 Performance Benchmark Report

Comparing 3.0 (baseline) vs fix-omit-events (current)

📈 Detailed Results (All Benchmarks)

📋 Complete results for all benchmarks - includes both significant and insignificant changes

🧪 Test Name	📏 Base	📏 Current	📈 Change	🎯 Status
Bloom Filter Dns Mutation Tracking Performance	4.27ms	4.24ms	-0.7% ⚪	✅
Bloom Filter Large Scale Dns Brute Force	17.72ms	17.51ms	-1.2% ⚪	✅
Large Closest Match Lookup	364.20ms	347.45ms	-4.6% ⚪	✅
Realistic Closest Match Workload	192.54ms	192.86ms	+0.2% ⚪	✅
Event Validation Full Scan Startup Small Batch	511.15ms	518.12ms	+1.4% ⚪	✅
Event Validation Full Scan Startup Large Batch	915.35ms	926.22ms	+1.2% ⚪	✅
Make Event Autodetection Small	31.27ms	31.07ms	-0.6% ⚪	✅
Make Event Autodetection Large	315.15ms	315.48ms	+0.1% ⚪	✅
Make Event Explicit Types	13.88ms	14.07ms	+1.4% ⚪	✅
Excavate Single Thread Small	4.114s	4.156s	+1.0% ⚪	✅
Excavate Single Thread Large	9.799s	9.968s	+1.7% ⚪	✅
Excavate Parallel Tasks Small	4.303s	4.368s	+1.5% ⚪	✅
Excavate Parallel Tasks Large	7.381s	7.458s	+1.0% ⚪	✅
Is Ip Performance	3.14ms	3.20ms	+2.1% ⚪	✅
Make Ip Type Performance	11.36ms	11.46ms	+0.9% ⚪	✅
Mixed Ip Operations	4.49ms	4.49ms	-0.1% ⚪	✅
Typical Queue Shuffle	61.61µs	60.40µs	-2.0% ⚪	✅
Priority Queue Shuffle	696.01µs	689.63µs	-0.9% ⚪	✅

🎯 Performance Summary

✅ No significant performance changes detected (all changes <10%)

---

🐍 Python Version 3.11.14

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92%. Comparing base (86fb46d) to head (80c92c8).
⚠️ Report is 4 commits behind head on 3.0.

Additional details and impacted files

@@          Coverage Diff          @@
##             3.0   #2934   +/-   ##
=====================================
- Coverage     92%     92%   -0%     
=====================================
  Files        434     434           
  Lines      35501   35515   +14     
=====================================
- Hits       32399   32392    -7     
- Misses      3102    3123   +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.