baddns 2.0.0 / badsecrets 1.0.0 compatibility#2933
Merged
Conversation
Collaborator
Author
|
do not merge until badsecrets 1.0 and baddns 2.0 are released. |
Contributor
Performance Benchmark Report
|
TheTechromancer
approved these changes
Mar 2, 2026
- Add submodule auto-filter: disable submodules whose max severity/confidence is below configured thresholds (avoids running expensive submodules for nothing) - Create baddns.yml base preset (CNAME, MX, TXT) and baddns-heavy.yml (all submodules) - Rename spider-intense→spider-heavy, baddns-intense→baddns-heavy - Fix baddns_zone default min_severity to INFORMATIONAL (NSEC/zonetransfer need it) - Update kitchen-sink.yml, remove stale enable_references v1.x config - Fix baddns_zone NSEC test (bad.dns→bad.com for tldextract compatibility) - Fix baddns_direct test (updated signature matcher for baddns 2.0) - Update all preset warning messages and docs references
…r-version-compat # Conflicts: # bbot/modules/baddns_direct.py # bbot/modules/badsecrets.py # docs/modules/lightfuzz.md # docs/scanning/presets_list.md
Reset the global asndb_client after cleanup so subsequent ASNDB() calls create a fresh client instead of returning a closed one.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.0 #2933 +/- ##
======================================
+ Coverage 91% 91% +1%
======================================
Files 436 436
Lines 36784 36892 +108
======================================
+ Hits 33440 33551 +111
+ Misses 3344 3341 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
liquidsec
force-pushed
the
badsecrets-baddns-major-version-compat
branch
2 times, most recently
from
54aa7d6 to
19e5d6a
Compare
…/confidence sync, add baddns dev dep
liquidsec
force-pushed
the
badsecrets-baddns-major-version-compat
branch
from
19e5d6a to
44ffba1
Compare
aconite33
pushed a commit
that referenced
this pull request
Mar 23, 2026
…major-version-compat baddns 2.0.0 / badsecrets 1.0.0 compatibility
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
only_high_confidenceboolean withmin_severity/min_confidencethreshold options (defaults:LOW/MODERATE)ASPNET_Resourceto technology detection (new module in badsecrets 1.0.0)baddns~=2.0.0,badsecrets~=1.0.0Note: Tests will fail until baddns 2.0.0 and badsecrets 1.0.0 are published to PyPI.