Skip to content

Otx fix#2839

Merged
TheTechromancer merged 7 commits into
devfrom
otx-fix
Dec 28, 2025
Merged

Otx fix#2839
TheTechromancer merged 7 commits into
devfrom
otx-fix

Conversation

@shart123456

Copy link
Copy Markdown
Contributor

No description provided.

@shart123456 shart123456 marked this pull request as draft December 16, 2025 19:13
@github-actions

github-actions Bot commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

📊 Performance Benchmark Report

Comparing dev (baseline) vs otx-fix (current)

📈 Detailed Results (All Benchmarks)

📋 Complete results for all benchmarks - includes both significant and insignificant changes

🧪 Test Name 📏 Base 📏 Current 📈 Change 🎯 Status
Bloom Filter Dns Mutation Tracking Performance 4.29ms 4.26ms -0.9%
Bloom Filter Large Scale Dns Brute Force 18.18ms 17.96ms -1.2%
Large Closest Match Lookup 362.40ms 352.46ms -2.7%
Realistic Closest Match Workload 197.98ms 195.27ms -1.4%
Event Validation Full Scan Startup Small Batch 455.00ms 464.71ms +2.1%
Event Validation Full Scan Startup Large Batch 803.90ms 808.39ms +0.6%
Make Event Autodetection Small 32.15ms 31.57ms -1.8%
Make Event Autodetection Large 321.98ms 323.16ms +0.4%
Make Event Explicit Types 14.15ms 14.22ms +0.5%
Excavate Single Thread Small 4.109s 4.087s -0.5%
Excavate Single Thread Large 9.589s 9.605s +0.2%
Excavate Parallel Tasks Small 4.280s 4.263s -0.4%
Excavate Parallel Tasks Large 7.174s 7.185s +0.1%
Is Ip Performance 3.18ms 3.20ms +0.6%
Make Ip Type Performance 11.56ms 11.54ms -0.2%
Mixed Ip Operations 4.56ms 4.55ms -0.2%
Typical Queue Shuffle 61.67µs 62.20µs +0.9%
Priority Queue Shuffle 696.37µs 688.91µs -1.1%

🎯 Performance Summary

No significant performance changes detected (all changes <10%)


🐍 Python Version 3.11.14

Comment thread bbot/defaults.yml Outdated
filter_ptrs: true
# Enable/disable debug messages for DNS queries
debug: false
debug: true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we changing global defaults?

@TheTechromancer

Copy link
Copy Markdown
Contributor

Nice work on this, I can take it from here.

@TheTechromancer TheTechromancer marked this pull request as ready for review December 25, 2025 22:46
@codecov

codecov Bot commented Dec 25, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92%. Comparing base (61b8a63) to head (fd700e2).
⚠️ Report is 8 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2839   +/-   ##
=====================================
- Coverage     92%     92%   -0%     
=====================================
  Files        409     409           
  Lines      34001   34007    +6     
=====================================
+ Hits       31004   31006    +2     
- Misses      2997    3001    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheTechromancer TheTechromancer merged commit 2e792da into dev Dec 28, 2025
13 of 17 checks passed
@liquidsec liquidsec mentioned this pull request Jun 9, 2026
@liquidsec liquidsec deleted the otx-fix branch June 10, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants