Skip to content

Separate update_event from make_event#2791

Merged
liquidsec merged 10 commits into
devfrom
make-event-nomenclature
Dec 5, 2025
Merged

Separate update_event from make_event#2791
liquidsec merged 10 commits into
devfrom
make-event-nomenclature

Conversation

@liquidsec

Copy link
Copy Markdown
Collaborator

Previously make_event() handled both creation of new events, and updating old ones. Causing some confusion based on the name of the function.

This PR separates the functions out cleanly into make_event and update_event.

@github-actions

github-actions Bot commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

📊 Performance Benchmark Report

Comparing dev (baseline) vs make-event-nomenclature (current)

📈 Detailed Results (All Benchmarks)

📋 Complete results for all benchmarks - includes both significant and insignificant changes

🧪 Test Name 📏 Base 📏 Current 📈 Change 🎯 Status
Bloom Filter Dns Mutation Tracking Performance 4.26ms 4.20ms -1.3%
Bloom Filter Large Scale Dns Brute Force 18.00ms 17.97ms -0.1%
Large Closest Match Lookup 350.18ms 361.91ms +3.3%
Realistic Closest Match Workload 192.20ms 193.73ms +0.8%
Event Validation Full Scan Startup Small Batch 456.11ms 468.91ms +2.8%
Event Validation Full Scan Startup Large Batch 808.89ms 807.48ms -0.2%
Make Event Autodetection Small 31.29ms 31.34ms +0.1%
Make Event Autodetection Large 321.73ms 315.02ms -2.1%
Make Event Explicit Types 14.24ms 13.90ms -2.4%
Excavate Single Thread Small 4.108s 3.978s -3.2%
Excavate Single Thread Large 9.558s 9.349s -2.2%
Excavate Parallel Tasks Small 4.139s 4.124s -0.4%
Excavate Parallel Tasks Large 7.102s 7.021s -1.1%
Is Ip Performance 3.16ms 3.18ms +0.4%
Make Ip Type Performance 11.45ms 11.52ms +0.6%
Mixed Ip Operations 4.52ms 4.50ms -0.4%
Typical Queue Shuffle 61.95µs 61.59µs -0.6%
Priority Queue Shuffle 695.46µs 694.63µs -0.1%

🎯 Performance Summary

No significant performance changes detected (all changes <10%)


🐍 Python Version 3.11.14

@codecov

codecov Bot commented Dec 5, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.38739% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 92%. Comparing base (859b2c1) to head (c06fdf5).
⚠️ Report is 27 commits behind head on dev.

Files with missing lines Patch % Lines
bbot/core/event/base.py 90% 7 Missing ⚠️
bbot/modules/base.py 69% 7 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2791   +/-   ##
=====================================
- Coverage     92%     92%   -0%     
=====================================
  Files        411     411           
  Lines      34013   34044   +31     
=====================================
+ Hits       31041   31064   +23     
- Misses      2972    2980    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread bbot/core/event/base.py Outdated
@liquidsec liquidsec merged commit e245c99 into dev Dec 5, 2025
15 of 16 checks passed
@liquidsec liquidsec deleted the make-event-nomenclature branch December 5, 2025 22:53
@liquidsec liquidsec mentioned this pull request Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants