Skip to content

Scope Rework#2789

Merged
TheTechromancer merged 51 commits into
3.0from
scope-rework
Dec 18, 2025
Merged

Scope Rework#2789
TheTechromancer merged 51 commits into
3.0from
scope-rework

Conversation

@liquidsec

@liquidsec liquidsec commented Nov 20, 2025

Copy link
Copy Markdown
Collaborator

Scope Rework: Whitelist → Target, Seeds Separation

Overview

This PR implements a scope rework that removes "whitelist" terminology and properly separates "seeds" from "target" conceptually. The term "whitelist" has been replaced with "target" throughout the codebase, and seeds are now a distinct concept that drives passive modules independently of what's considered in-scope.

Key Changes

Terminology Updates:

  • whitelist → target (what in_target() checks)
  • whitelisted() → in_target() method
  • target_scope → target_list parameter
  • ScanWhitelist → ScanTarget class

Seeds vs Target Separation:

  • Seeds: Initial events that drive passive modules (CLI: -s/--seeds, Python: seeds=)
  • Target: What in_target() checks (CLI: -t/--targets, Python: target_list= or positional args)
  • Seeds default to targets if not explicitly specified, but are backfilled from target.inputs in BBOTTarget
  • Positional arguments in Python API always mean target (never seeds)

CLI Changes:

  • Removed -w/--whitelist flag
  • -s/--seeds now defines seeds (was --silent)
  • -S/--silent for silent mode (was -s)

Breaking Changes

No backward compatibility for whitelist/target_scope
CLI flag changes: -s now means seeds, -S means silent

@liquidsec liquidsec marked this pull request as draft November 20, 2025 20:41
@liquidsec liquidsec changed the title scope rework initial Scope Rework Nov 20, 2025
@github-actions

github-actions Bot commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

📊 Performance Benchmark Report

Comparing 3.0 (baseline) vs scope-rework (current)

📈 Detailed Results (All Benchmarks)

📋 Complete results for all benchmarks - includes both significant and insignificant changes

🧪 Test Name 📏 Base 📏 Current 📈 Change 🎯 Status
Bloom Filter Dns Mutation Tracking Performance 4.19ms 4.17ms -0.5%
Bloom Filter Large Scale Dns Brute Force 17.70ms 17.43ms -1.5%
Large Closest Match Lookup 355.14ms 354.97ms -0.0%
Realistic Closest Match Workload 192.89ms 190.53ms -1.2%
Event Validation Full Scan Startup Small Batch 463.80ms 478.78ms +3.2%
Event Validation Full Scan Startup Large Batch 810.09ms 885.46ms +9.3%
Make Event Autodetection Small 31.44ms 30.83ms -1.9%
Make Event Autodetection Large 319.75ms 315.76ms -1.2%
Make Event Explicit Types 13.98ms 13.72ms -1.9%
Excavate Single Thread Small 4.025s 3.964s -1.5%
Excavate Single Thread Large 9.454s 9.440s -0.2%
Excavate Parallel Tasks Small 4.119s 4.109s -0.2%
Excavate Parallel Tasks Large 7.021s 7.008s -0.2%
Is Ip Performance 3.15ms 3.17ms +0.7%
Make Ip Type Performance 11.58ms 11.50ms -0.7%
Mixed Ip Operations 4.52ms 4.51ms -0.2%
Typical Queue Shuffle 61.07µs 61.74µs +1.1%
Priority Queue Shuffle 692.24µs 711.39µs +2.8%

🎯 Performance Summary

No significant performance changes detected (all changes <10%)


🐍 Python Version 3.11.14

@liquidsec liquidsec marked this pull request as ready for review December 3, 2025 19:46
@TheTechromancer TheTechromancer merged commit 95b5dd4 into 3.0 Dec 18, 2025
12 of 15 checks passed
@liquidsec liquidsec mentioned this pull request Jun 9, 2026
@liquidsec liquidsec deleted the scope-rework branch June 10, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants