Fix Baddns IPv4 event.host bug#2196
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2196 +/- ##
=====================================
+ Coverage 93% 93% +1%
=====================================
Files 376 376
Lines 29224 29225 +1
=====================================
+ Hits 27004 27008 +4
+ Misses 2220 2217 -3 ☔ View full report in Codecov by Sentry. |
| if str(event.module).startswith("bucket_"): | ||
| return False | ||
| self.debug(f"Processing STORAGE_BUCKET for {event.host}") | ||
| self.debug(f"Processing STORAGE_BUCKET for {str(event.host)}") |
Contributor
There was a problem hiding this comment.
it's not necessary to use str() inside format strings since they're converted automatically.
Collaborator
Author
|
@TheTechromancer should be good now |
TheTechromancer
approved these changes
Jan 21, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ensure event.host is stringified before passing to baddns