Skip to content

Add nuclei presets#2188

Merged
TheTechromancer merged 7 commits into
devfrom
nuclei-presets
Jan 23, 2025
Merged

Add nuclei presets#2188
TheTechromancer merged 7 commits into
devfrom
nuclei-presets

Conversation

@liquidsec

Copy link
Copy Markdown
Collaborator

todo:

  • Update docs whenever presets are finalized

Comment thread bbot/presets/nuclei/nuclei-budget.yml Outdated
Comment thread bbot/presets/nuclei/nuclei-intense.yml
Comment thread bbot/presets/nuclei/nuclei-intense.yml Outdated
directory_only: True # Do not run nuclei on individual non-directory URLs
web:
spider_distance: 1
spider_depth: 3

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to enable the spider in the nuclei presets? Personally I think it makes sense to keep them separate, since if you want to enable both it's as easy as -p nuclei spider. If we want to have multiple spider presets like spider-light, spider-max, etc., that might make sense though.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my thinking here was just to explicitly set them, one way or another, because of how dramatic the difference in the scan will be. I figured including the 0 settings, even though they are default, would help people understand the differences when they examine the yml files.

How would you feel about doing spider-light/max whatever and including them?

if so, would it make sense to have spider-none or should we just lean on the defaults with that?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would make more sense but I still think that in order to spider things, the user should have to explicitly enable it. including it in presets makes it too easy to accidentally enable.

Another problem with explicitly setting them in the preset, is that depending on how you order your presets, you'll get different results. I.e. -p spider nuclei-budget won't spider, but -p nuclei-budget spider will.

@liquidsec liquidsec Jan 17, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another problem with explicitly setting them in the preset, is that depending on how you order your presets, you'll get different results. I.e. -p spider nuclei-budget won't spider, but -p nuclei-budget spider will.

To be honest, i don't like this - or at least not unless this behavior is explained pretty well at runtime.

I know we talked about preset conflict resolution and didn't go that route, and i know all of the pitfalls associated with that. At this point a message when you have multiple presets explaining this behavior is probably ok.

I am fine with making the user define them separately, however, alot of the other settings don't make any sense unless spider is turned on.

Later when we deal with lightfuzz presets, spidering is essentially an absolute requirement, and thats why they are hardcoded there.

Just imagining my own use of these, i'd rather not remember to have to turn on an additional preset just to get the preset to function as intended.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also given the order matters for presets, if we did go the route of having spider-light spider-heavy or whatever, it would actually make sense in that situation to have spider-none, to nullify spidering which is enabled in a different preset

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov

codecov Bot commented Jan 17, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93%. Comparing base (b7d12e9) to head (b3a0441).
Report is 42 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2188   +/-   ##
=====================================
+ Coverage     93%     93%   +1%     
=====================================
  Files        376     378    +2     
  Lines      29224   29282   +58     
=====================================
+ Hits       27004   27067   +63     
+ Misses      2220    2215    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTechromancer
TheTechromancer merged commit 958af4a into dev Jan 23, 2025
@liquidsec
liquidsec deleted the nuclei-presets branch January 28, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants