Skip to content

Fix wildcard deduplication#1972

Merged
TheTechromancer merged 1 commit into
devfrom
fix-wildcard-dedup
Nov 18, 2024
Merged

Fix wildcard deduplication#1972
TheTechromancer merged 1 commit into
devfrom
fix-wildcard-dedup

Conversation

@TheTechromancer

Copy link
Copy Markdown
Contributor

Fixes #1859.

The problem was that the deduplication was happening before the event's data was changed to _wildcard. The solution was to make an additional dedup check after the data is changed.

@codecov

codecov Bot commented Nov 17, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 93%. Comparing base (a55e9dd) to head (0c5220e).
Report is 25 commits behind head on dev.

Files with missing lines Patch % Lines
bbot/modules/internal/dnsresolve.py 88% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #1972   +/-   ##
=====================================
- Coverage     93%     93%   -0%     
=====================================
  Files        365     365           
  Lines      27915   27941   +26     
=====================================
+ Hits       25739   25746    +7     
- Misses      2176    2195   +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@TheTechromancer
TheTechromancer merged commit e3e321a into dev Nov 18, 2024
@liquidsec
liquidsec deleted the fix-wildcard-dedup branch January 13, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants