[PM-38964] Remove obsolete LockScreen config from AppX manifest#21229
Open
hammadxcm wants to merge 1 commit into
Open
[PM-38964] Remove obsolete LockScreen config from AppX manifest#21229hammadxcm wants to merge 1 commit into
hammadxcm wants to merge 1 commit into
Conversation
The desktop client no longer supports live tiles or badge notifications on Windows 10/11, but the LockScreen declaration in the AppX manifest still causes Bitwarden to appear as a selectable lock screen status app in Windows Settings. Remove the LockScreen element from the custom AppX manifest template and delete the now-unused BadgeLogo asset so electron-builder no longer injects the equivalent element into the generated manifest.
|
|
Collaborator
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
bitwarden-bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
Closes #16746
📔 Objective
The desktop client no longer supports live tiles or badge notifications on Windows 10/11, yet Bitwarden still shows up as a selectable "Lock screen status" app under Windows Settings → Personalization → Lock screen (
ms-settings:lockscreen) when installed from the Microsoft Store.This PR removes the obsolete configuration:
<uap:LockScreen Notification="badgeAndTileText" BadgeLogo="assets\BadgeLogo.png" />element fromapps/desktop/custom-appx-manifest.xml.apps/desktop/resources/appx/BadgeLogo.pngasset, so electron-builder no longer injects an equivalent<uap:LockScreen>element into the manifest it generates (electron-builder adds that element automatically whenever aBadgeLogo.pngasset is present)..github/whitelist-capital-letters.txt.After this change Bitwarden no longer appears as a lock screen status app option.
Note: a previous PR with the same change (#18137) was approved by maintainers but closed by its author; this PR re-applies that change on top of the current
main.