fix(ContentSearch/DashboardSearch): proxy missing CommandPalette props - #70
Merged
Merged
Conversation
Forward the additional CommandPalette props (trailingIcon, selectedIcon, childrenIcon, back, backIcon, disabled, highlightOnHover, labelKey, descriptionKey, preserveGroupOrder, virtualize) through both the props interface (Pick) and reactivePick, in DashboardSearch and ContentSearch. All forwarded props verified to exist on b24ui's CommandPalette. b24ui does not expose loadingIcon on these wrappers (pre-existing divergence) so it is left untouched. Upstream: nuxt/ui@631f5dc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live sync — commit 2/20 (real port)
Upstream:
631f5dc543— fix(ContentSearch/DashboardSearch): proxy missing CommandPalette props (#6505)What this does
Forwards the additional
CommandPaletteprops through theDashboardSearchandContentSearchwrappers — in both the props interface (Pick<…>) and thereactivePick(…)forwarding:trailingIcon, selectedIcon, childrenIcon, back, backIcon, disabled, highlightOnHover, labelKey, descriptionKey, preserveGroupOrder, virtualizeFaithfulness / divergence notes
CommandPalette, so they proxy correctly.loadingIconon these two wrappers (pre-existing divergence — it's absent from b24ui's basePick/reactivePick). This commit does not introduce it; only the 11 new props are added.Validation (run locally)
eslint(both files)vue-tsc --noEmitvitest run DashboardSearch— 30 passed, snapshots unchanged (forwarding unset props doesn't change render)https://claude.ai/code/session_01Qz7EXMncvEGiCj4WbmYgJo
Generated by Claude Code