chore(sync): record the clientBundle.scan icons doc as a no-op - #490
Merged
Conversation
Ports nuxt/ui `bb55709f` (#6880) as a no-op: the mechanism it documents does not
exist in this fork.
Upstream adds 40 lines to both icons integration pages explaining the limits of
`@nuxt/icon`'s client bundle scanner — which file extensions it reads, that it
matches icon names only as literal strings so a list in a `.ts` file or a name
built as `` `i-lucide-${name}` `` is missed, how `globInclude` widens that list,
and that runtime-only names cannot be bundled at all.
None of that applies here, checked rather than assumed. Our icons are
`@bitrix24/b24icons` Vue **components**, imported by name and bundled by the
compiler, so there is no string-literal icon name to scan for and the failure
mode the paragraph warns about cannot arise. `clientBundle`, `globInclude` and
`/api/_nuxt_icon` appear nowhere in `docs/` or `src/`; `@nuxt/icon` survives only
as a commented-out block at `src/module.ts:139` and as prose inside an unrelated
Accordion example. Both of our icons pages document `@bitrix24/b24icons` with
automatic setup and no scanner to configure.
Same call, and the same reason, as `08e75317`.
Ledger: cursor → `bb55709f` (upstream HEAD), parity snapshot refreshed.
3 tasks
IgorShevchik
added a commit
that referenced
this pull request
Aug 25, 2026
The entry was written with `pending-merge` because the PR carrying it had not merged yet; it now points at #490 and its squash SHA `95d73045`. No entry in the ledger is left unreconciled, and the cursor `bb55709f` is upstream HEAD. Bookkeeping only — no source, test or docs change. Co-authored-by: Shevchik Igor <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Sync with
nuxt/ui@v4—bb55709f(nuxt/ui#6880). After this the cursor is at upstream HEAD.Type of change
Description
Upstream adds 40 lines to both icons integration pages, explaining the limits of
@nuxt/icon's client bundle scanner: which file extensions it reads, that it matches icon names only as literal strings — so a list of links in a.tsfile is missed, as is anything built like`i-lucide-${name}`— howclientBundle.scan.globIncludewidens that list by replacing the default, and that names existing only at runtime cannot be bundled and are fetched from/api/_nuxt_iconunder SSR or the Iconify API otherwise.None of that machinery exists here, checked rather than assumed:
@bitrix24/b24icons— Vue components, imported by name and bundled by the compiler. There is no string-literal icon name to scan for, so the failure mode the paragraph warns about cannot arise in the first place.clientBundle,globIncludeand/api/_nuxt_iconappear nowhere indocs/orsrc/.@nuxt/iconsurvives in exactly two places, neither a dependency: a commented-out block atsrc/module.ts:139, and prose inside an unrelated Accordion example.@bitrix24/b24iconsand its 1,400+ icons, and state that setup is automatic — there is no scanner to configure.Same call, and the same reason, as
08e75317(docs: resolve icon load failures during prerender), which the ledger records as a port of only its non-icon half.Recorded rather than skipped silently so the next porter does not re-derive it.
Verification
Ledger only — no source, test or docs change. Cursor →
bb55709f, which is upstream HEAD; parity snapshot refreshed to it with zero package differences, andtest/utils/dep-parity.spec.tspasses in full (22 assertions).Checklist
Generated by Claude Code