Skip to content

chore(sync): record the clientBundle.scan icons doc as a no-op - #490

Merged
IgorShevchik merged 1 commit into
mainfrom
sync/nuxt-bb55709f
Aug 25, 2026
Merged

chore(sync): record the clientBundle.scan icons doc as a no-op#490
IgorShevchik merged 1 commit into
mainfrom
sync/nuxt-bb55709f

Conversation

@IgorShevchik

Copy link
Copy Markdown
Collaborator

Linked issue

Sync with nuxt/ui@v4bb55709f (nuxt/ui#6880). After this the cursor is at upstream HEAD.

Type of change

  • Chore (updates to the build process or auxiliary tools and libraries)

Description

Upstream adds 40 lines to both icons integration pages, explaining the limits of @nuxt/icon's client bundle scanner: which file extensions it reads, that it matches icon names only as literal strings — so a list of links in a .ts file is missed, as is anything built like `i-lucide-${name}` — how clientBundle.scan.globInclude widens that list by replacing the default, and that names existing only at runtime cannot be bundled and are fetched from /api/_nuxt_icon under SSR or the Iconify API otherwise.

None of that machinery exists here, checked rather than assumed:

  • Our icons are @bitrix24/b24icons — Vue components, imported by name and bundled by the compiler. There is no string-literal icon name to scan for, so the failure mode the paragraph warns about cannot arise in the first place.
  • clientBundle, globInclude and /api/_nuxt_icon appear nowhere in docs/ or src/.
  • @nuxt/icon survives in exactly two places, neither a dependency: a commented-out block at src/module.ts:139, and prose inside an unrelated Accordion example.
  • Both of our icons pages document @bitrix24/b24icons and its 1,400+ icons, and state that setup is automatic — there is no scanner to configure.

Same call, and the same reason, as 08e75317 (docs: resolve icon load failures during prerender), which the ledger records as a port of only its non-icon half.

Recorded rather than skipped silently so the next porter does not re-derive it.

Verification

Ledger only — no source, test or docs change. Cursor → bb55709f, which is upstream HEAD; parity snapshot refreshed to it with zero package differences, and test/utils/dep-parity.spec.ts passes in full (22 assertions).

Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Generated by Claude Code

Ports nuxt/ui `bb55709f` (#6880) as a no-op: the mechanism it documents does not
exist in this fork.

Upstream adds 40 lines to both icons integration pages explaining the limits of
`@nuxt/icon`'s client bundle scanner — which file extensions it reads, that it
matches icon names only as literal strings so a list in a `.ts` file or a name
built as `` `i-lucide-${name}` `` is missed, how `globInclude` widens that list,
and that runtime-only names cannot be bundled at all.

None of that applies here, checked rather than assumed. Our icons are
`@bitrix24/b24icons` Vue **components**, imported by name and bundled by the
compiler, so there is no string-literal icon name to scan for and the failure
mode the paragraph warns about cannot arise. `clientBundle`, `globInclude` and
`/api/_nuxt_icon` appear nowhere in `docs/` or `src/`; `@nuxt/icon` survives only
as a commented-out block at `src/module.ts:139` and as prose inside an unrelated
Accordion example. Both of our icons pages document `@bitrix24/b24icons` with
automatic setup and no scanner to configure.

Same call, and the same reason, as `08e75317`.

Ledger: cursor → `bb55709f` (upstream HEAD), parity snapshot refreshed.
@IgorShevchik
IgorShevchik merged commit 95d7304 into main Aug 25, 2026
2 checks passed
@IgorShevchik
IgorShevchik deleted the sync/nuxt-bb55709f branch August 25, 2026 07:05
IgorShevchik added a commit that referenced this pull request Aug 25, 2026
The entry was written with `pending-merge` because the PR carrying it had not
merged yet; it now points at #490 and its squash SHA `95d73045`. No entry in the
ledger is left unreconciled, and the cursor `bb55709f` is upstream HEAD.

Bookkeeping only — no source, test or docs change.

Co-authored-by: Shevchik Igor <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants