Skip to content

docs(table): pin TanStack Table links to v8 - #445

Merged
IgorShevchik merged 1 commit into
mainfrom
sync/nuxt-545f9e3
Aug 20, 2026
Merged

docs(table): pin TanStack Table links to v8#445
IgorShevchik merged 1 commit into
mainfrom
sync/nuxt-545f9e3

Conversation

@IgorShevchik

Copy link
Copy Markdown
Collaborator

Ports the two commits upstream landed after the last run closed. Adjacent, so batched per PORTING.md §6 step 4b.

1. nuxt/ui@545f9e37fix(Icon): render bundled icons during SSR in Vueno-op

There is no Icon component in this fork at all. find src -name 'Icon.vue' returns nothing, and src/runtime/vue/components/ holds only color-mode.

By design rather than omission, and already on record: the §1 component comparison added in #423 lists Icon and prose/Icon among the nineteen names that exist only upstream. b24ui has no icon wrapper — icons are @bitrix24/b24icons-vue components, imported and rendered directly, which is why data-slot="icon" appears 6672 times across the snapshots and no component ever passes a name string.

No SSR path to fix.

2. nuxt/ui@be58f3f5docs(table): pin TanStack Table links to v8ported

latest now resolves to a major whose API the documentation no longer matches.

It applies here for the same reason, checked rather than assumed: this fork depends on @tanstack/vue-table ^8.21.3, so every latest link documents an API our Table does not implement.

18 links across two files — docs/content/docs/2.components/table.md (17) and skills/b24-ui-nuxt/references/recipes/data-tables.md (1) — plus the two labels upstream widened to name the version.

The mislabelled link is inherited too

Our line 523, in With column pinning, read:

the TanStack Table Pinning APIs

pointing at row pinning from the column-pinning section. Now [Column Pinning APIs](…/features/column-pinning), matching upstream's fix.

Worth separating from the version pin: that one is a content error, and a sweep of latestv8 alone would have carried it forward untouched — which is what makes reading the diff worth more than replaying it.

Not applicable

docs/content/docs/1.getting-started/3.migration/2.v3.md. Our migration directory holds only 1.v2.md; this fork has no v3 migration page.

Verify (CI=true)

lint · test · docs:generate — all green. Tests 6790 passed | 6 skipped across 298 files, 1255 routes prerendered.

Documentation only — no component, theme or type is touched. Zero tanstack.com/table/latest remain; 18 tanstack.com/table/v8.

Ledger

cursorbe58f3f5, both entries and logs added, .sync/dep-parity.json refreshed. A bookkeeping PR follows to fill in their pr/b24ui_sha.


Generated by Claude Code

Ports two contiguous upstream commits, batched per PORTING.md §6 step 4b.

nuxt/ui@545f9e37 `fix(Icon): render bundled icons during SSR in Vue` —
no-op. There is no `Icon` component in this fork at all: `find src -name
'Icon.vue'` returns nothing and `src/runtime/vue/components/` holds only
`color-mode`. By design rather than omission, and already recorded — the §1
component comparison from #423 lists `Icon` and `prose/Icon` among the
nineteen names that exist only upstream. Icons here are
`@bitrix24/b24icons-vue` components imported and rendered directly, so
there is no SSR path to fix.

nuxt/ui@be58f3f5 `docs(table): pin TanStack Table links to v8` — ported.
`latest` now resolves to a major whose API the documentation no longer
matches. It applies here for the same reason, checked rather than assumed:
this fork depends on `@tanstack/vue-table ^8.21.3`, so every `latest` link
documents an API our Table does not implement.

18 links across `docs/content/docs/2.components/table.md` and
`skills/b24-ui-nuxt/references/recipes/data-tables.md`, plus the two labels
upstream widened to name the version.

We inherit the mislabelled link too. Line 523, in *With column pinning*,
pointed at the **row** pinning API; it now points at column pinning. Worth
separating from the version pin: that one is a content error, and a sweep
of `latest` -> `v8` alone would have carried it forward untouched.

Not applicable: `docs/.../3.migration/2.v3.md`. Our migration directory
holds only `1.v2.md` — this fork has no v3 migration page.

Verify (CI=true): lint · test (6790 passed, 6 skipped, 298 files) ·
docs:generate (1255 routes) — all green. Documentation only. Zero
`tanstack.com/table/latest` remain; 18 `tanstack.com/table/v8`.
@IgorShevchik
IgorShevchik merged commit fc562bc into main Aug 20, 2026
1 check passed
@IgorShevchik
IgorShevchik deleted the sync/nuxt-545f9e3 branch August 20, 2026 03:52
IgorShevchik added a commit that referenced this pull request Aug 20, 2026
)

Bookkeeping only, per PORTING.md §6 step 4: the last entries of a run
cannot name their own merge, so they land as `pending-merge` and a
follow-up fills them in. Both merged in #445, squash `fc562bce`.

No `pending-merge` remains. 263 entries, and `cursor` is `be58f3f5`.

`.sync/dep-parity.json` already sits at this cursor; #445 refreshed it.

Four JSON fields. Verified with lint and the `test/utils` suite, where both
specs that read `.sync/` live — `icon-map.spec.ts` and `dep-parity.spec.ts`,
the latter comparing this file's `cursor` against the snapshot's.

Co-authored-by: Shevchik Igor <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants