chore(sync): record the volta.net and triadtrainer showcase entries as no-ops - #442
Merged
Conversation
…s no-ops Two contiguous upstream commits, batched per PORTING.md §6 step 4b. No code changes. nuxt/ui@2beb2345 and nuxt/ui@a630c943 each add two lines to `docs/content/showcase.yml` plus a screenshot, listing another site built with Nuxt UI. We have that file, but it lists projects built with Bitrix24 UI — its own description says so — and adding a site built on nuxt/ui would make the page assert something false. Content, not structure. Same call as `cf5f15e3` and `f6d188bd`; recorded so the next porter does not derive it a fourth time. Also refreshes `.sync/dep-parity.json` to the new cursor, per §6. Neither commit touches a manifest, so only the cursor line moves and all 148 versions are identical. Verify (CI=true): lint and the `test/utils` suite (495 tests, 25 files). Ledger and documentation only.
IgorShevchik
pushed a commit
that referenced
this pull request
Aug 23, 2026
Review found six defects in the two checks this branch adds, three of them undermining the point of it. Every one was confirmed by running rather than reading. **The type check could be walked past.** `/^([a-z]+)/i` takes a letters-only prefix; the parser's type token runs to the first `(`, `!`, `:` or space. So `fix2(x):` read as `fix` and was accepted, `fix-perf(x):` as `fix`, and `2fix(x):` captured nothing at all — skipping the check and printing "type `undefined` has a section", next to a comment of mine calling that a case that could not happen. All three are types release-please would not match, which is the exact bypass this guard exists to close: a typo in letters was caught, a typo with a digit was not. The type now comes from the AST the parse already produced. The grammar has one implementation and it is not this file. Mutation then showed the fix had no test behind it — the original regex still passed all 75 cases, because every unconfigured type in the spec was letters. Four cases added. **The port check flagged commits that port nothing.** It keyed on any new entry in `processed`, but 70 of the ledger's entries are `no-op`, `noop`, `skip` or `n/a`. #442, #439 and #361 were all flagged — correct messages, on `main`, where they can no longer be fixed. The trigger is now a new entry whose `decision` is `port`. **The new tests would have failed every CI run.** They worktree'd onto real SHAs while this same branch sets `fetch-depth: 2`, so the objects are absent on CI; locally they passed only because a dev clone has the history. Rewritten against a synthetic two-commit repository, which also removes a race that bit this branch for real — a concurrent process restoring the same file twice discarded edits mid-review. Three smaller ones. A batch port was required to name every SHA it added, while §6 4b and this file's own docstring say naming one is enough. The ledger key was interpolated into `new RegExp`, so an entry keyed `(a+)+$` hangs the check — it is a substring test against a key checked to be a SHA now. And an unreadable ledger warned at HEAD^ but was silent at HEAD. Two coverage holes closed on review's evidence: disabling `isMergeCommit()` killed no test, and the "reads the type list from the config" test was a string-containment check that a hardcoded copy passes with the comment intact. It now stands the script beside a config naming a type this repository does not configure and requires it to be accepted. Docs corrected where they promised more than the code does. §7 said CI checks the upstream reference; it does, but only on `push` to `main` — the title job works from a title, which cannot say what a commit touched — so the reviewer owns both halves. `pr-title.yml` now says green there does not mean every rule is satisfied. `AGENTS.md` states both requirements, which until now were discoverable only by reddening CI. Nine mutations that previously killed nothing now each kill at least one case. Follow-up #472 covers the install cost of the title job. Refs #437 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012MsMuj8Fic9tjWVjyEyrxc
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth and fifth of six in the queue, after #441. Adjacent, so batched per
PORTING.md§6 step 4b. No code changes.nuxt/ui@2beb2345andnuxt/ui@a630c943each add two lines todocs/content/showcase.ymlplus a screenshot, listing another site built with Nuxt UI.We have that file, but it lists projects built with Bitrix24 UI — its own description says so — and adding a site built on nuxt/ui would make the page assert something false. Content, not structure.
Same call as
cf5f15e3andf6d188bd. Recorded rather than skipped silently so the next porter does not derive it a fourth time.Ledger
ae2bd5ebreconciled with #441 and squash62a2acc8.cursor→a630c943, both entries added withdecision: no-op,.sync/dep-parity.jsonrefreshed — neither commit touches a manifest, so only the cursor line moves and all 148 versions are identical.Verify (
CI=true)lintand thetest/utilssuite (495 tests, 25 files). Ledger and documentation only.What is left
14ac2438(ProgressGroup) is the last commit in the queue and is deliberately not batched in here, despite being contiguous. It has two halves that both need real work:--percentfix for the existingProgress— done and verified locally, held back so it ships with the commit it belongs to. It moves the status size out of an inlinewidth/height, which beat any class a consumer passed throughb24ui.status, into a CSS variable the theme reads. This fork'sfit-contentfallback (upstream has none) is preserved and now has its first test, verified by mutation;ProgressGroupitself, which is a genuine design adaptation rather than a translation. Upstream colours the indicator withbg-{color}per segment; here colour is astyle-filled*class on the root that defines--b24ui-background, which the indicator reads. Per-segment colour therefore means moving that class onto the segment and the legend dot, and deciding how the leading icon takes its colour. That is a decision about the design system, not a port, and it deserves its own PR rather than being rushed in behind two showcase no-ops.Generated by Claude Code