PLZ-1095 Mitigate a race condition creating child revisions#16
Merged
Conversation
When running `plz review` from the CLI, if plz.review processes the webhook for a child review's new revision before the webhook for its parent then the child will be orphaned, and the stack relationship will be broken. This is a hack to reduce the likelihood that a new revision in a child review is processed before a new revision in the parent review. The proper fix is to wait until any revisions that may be created by pushing the branch or updating the PR are created (e.g. by polling the API) before continuing on up the stack. plz-review-url: https://plz.review/review/5606
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
plz reviewfrom the CLI, if plz.review processes thewebhook for a child review's new revision before the webhook for its
parent then the child will be orphaned, and the stack relationship will
be broken. This is a hack to reduce the likelihood that a new revision
in a child review is processed before a new revision in the parent
review. The proper fix is to wait until any revisions that may be
created by pushing the branch or updating the PR are created (e.g. by
polling the API) before continuing on up the stack.
plz-review-url: https://plz.review/review/5606