Skip to content

Initialize JSON schemas lazily to avoid static initialization order issue #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
massis08 merged 1 commit into from
Oct 7, 2026
Merged

Initialize JSON schemas lazily to avoid static initialization order issue #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions Development/nmos/json_schema.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,14 @@ namespace nmos
return result;
}

static std::map<web::uri, web::json::value> schemas = make_schemas();
// Built on first use rather than during static initialization: make_schemas() parses JSON, and
// cpprestsdk's scoped_c_thread_locale::c_locale() is not safe to call before cpprestsdk's own
// globals are initialized (e.g. when the library is dlopen'ed while the process locale is not "C").
static const std::map<web::uri, web::json::value>& schemas()
{
static const std::map<web::uri, web::json::value> instance = make_schemas();
return instance;
}
}

namespace experimental
Expand Down Expand Up @@ -603,9 +610,11 @@ namespace nmos
// load the json schema for the specified base URI
web::json::value load_json_schema(const web::uri& id)
{
auto found = nmos::details::schemas.find(id);
const auto& schemas = nmos::details::schemas();

auto found = schemas.find(id);

if (nmos::details::schemas.end() == found)
if (schemas.end() == found)
{
throw web::json::json_exception((_XPLATSTR("schema not found for ") + id.to_string()).c_str());
}
Expand Down
Loading