Repository navigation
Correct converstion of file path to Uri - #6
Merged
Merged
Conversation
40 tasks done
adhorodyski
added a commit
to callstack-internal/Expensify-App
that referenced
this pull request
Aug 24, 2026
getFileUri built the URI by concatenation, so Uri.parse read a "#" in the path as a fragment and dropped the rest of the filename. On Android that truncation broke ReceiptStorage.adopt for files chosen through the document picker, which stayed in the app cache instead of reaching durable storage. The maintained fork carries the same one-line change: birdofpreyru/react-native-fs#6 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was using RNFS.readFile() on a file with
&in its name and was getting a file not found error. Traced it down to this line. Uri.fromFile() has been around since API Level 1.Full disclosure: I am currently using and tested this change on the original RNFS repo.