Repository navigation
Conversation
Chromium only enables gnome-libsecret or kwallet when it recognizes a GNOME/KDE desktop name, so niri/sway/Hyprland fall through to BASIC_TEXT even when org.freedesktop.secrets is available. Set --password-store before app ready when Secret Service is present, without overriding an explicit switch or KDE's kwallet default.
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4189
On Linux, Chromium picks the
safeStoragepassword backend fromXDG_CURRENT_DESKTOP. Non-GNOME/KDE compositors such as niri, sway, and Hyprland fall through toBASIC_TEXTeven when Secret Service (org.freedesktop.secrets) is available. Electron then reportssafeStorage.isEncryptionAvailable() === false, so local vault backups are refused and credential fields are stored as plaintext.This sets
--password-store=gnome-libsecretbeforeapp.whenReady()when:--password-storeorg.freedesktop.secretsGNOME and other Secret Service environments keep the same backend. Systems with no keyring keep today's fail-closed backup path and plaintext-credential fallback.
Focused tests:
node --test electron/linuxPasswordStore.test.cjs electron/startupMemoryGuards.test.cjs(17 pass).