Repository navigation
fix(i18n): complete zh-TW strings and unify Taiwan terminology - #4185
Open
ranrany123 wants to merge 2 commits into
Open
ranrany123 wants to merge 2 commits into
ranrany123 wants to merge 2 commits into
Conversation
- Translate the 19 settings.plugins.sources.* keys that were still in
Simplified Chinese, and add the 9 missing ai.providers.headers.* keys.
- Add the two zh-CN keys the dialog already looked up (createWorkspace.title,
field.selectHosts) so those labels no longer fall back to English.
- Keep {{name}} / {{name:default}} literal in snippets.field.variablesHelp;
the previous text translated the metavariable names.
- Unify zh-TW terms in the shipped UI: 外掛, 市集, 行程, 指令碼, 金鑰,
佔位符, 檔案系統, 網路, 資料, 使用者, 預設.
- Tighten localeParityLocales: zh-CN and zh-TW are at full parity, so move
them out of LOCALES_PENDING_PARITY and check interpolation placeholders for
every translated locale, not just es.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Review follow-up on the terminology pass:
- Replace the remaining mainland terms on the plugin settings screen:
導入→匯入, 卸載→解除安裝, 存儲→儲存, 遠程→遠端, 加載→載入. 網路設備 is
correct Taiwan usage and stays.
- Widen the interpolation token regex so {{name:default}} is compared too;
the previous \w+ form silently ignored the colon and could not catch a
translated metavariable. Add a direct assertion for that form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes user-visible localization gaps in the shipped UI: one block of Simplified Chinese in the Traditional Chinese locale, missing keys that fell back to English, translated metavariables, and mixed Taiwan terminology.
Type of Change
zh-CN/zh-TW)Related Issue (optional)
N/A
Changes Made
settings.plugins.sources.*values inzh-TW/core.tsthat were still Simplified Chinese.ai.providers.headers.*keys tozh-TW/ai.ts.dialog.createWorkspace.titleandfield.selectHoststozh-CN/core.ts;CreateWorkspaceDialogalready looked them up, so the labels rendered in English.{{name}}/{{name:default}}literal insnippets.field.variablesHelp(zh-CN and zh-TW). The previous text translated the metavariable names, so users copying the hint would create a variable literally called名称.外掛,市集,行程,指令碼,金鑰,佔位符,檔案系統,網路,資料,使用者,預設.localeParityLocales.test.ts:zh-CNandzh-TWare at full key parity, soLOCALES_PENDING_PARITYis now["ru"], and interpolation placeholders are checked for every translated locale instead of onlyes.Screenshots / Demo
No layout changes; strings only. The plugin-source dialog, AI provider header editor, and create-workspace dialog are the visible surfaces.
Testing
npm run devwas not needed; the strings were verified through the locale modules and tests)npm run lint)npm test) — the full suite was not run; the locale tests were run directly (below)npm run generate:capability-tools) — not applicableKey parity after the change:
zh-CN4686 keys,zh-TW4686 keys, 0 missing, 0 extra, 0 placeholder mismatches.Checklist