Repository navigation
Conversation
Owner
Author
|
@codex review |
2 tasks done
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Agents on builds that already include #3935 (
session_reconnect/session_recover) still reported “no reconnect MCP action” and fell back tohost_open(new tab). Those tools are deferred underload_netcatty_toolstoolsetsessions, but MCP server instructions and the netcatty-mcp skill omitted that toolset.Change
sessionsin MCP instructions + skill load guidance.session_reconnect/session_recoveroverhost_openfor disconnected in-scope sessions.No reconnect implementation changes; tools stay deferred (not promoted to core).
Note on releases
v1.1.90 predates #3935, so that build truly has no reconnect MCP tool. This PR only fixes discoverability on post-#3935 main; the capability itself ships with the next release that includes #3935.
Related #4181
Related #3935
Test plan
node --test electron/mcp/netcattyMcpInstructions.test.cjs(2/2 PASS)sessions, agent can callsession_reconnecton a disconnected scoped tab without opening a new host tab