Skip to content

fix: fit main windows and vault editor widths on small displays - #4178

Open
binaricat wants to merge 2 commits into
mainfrom
fix/4106-small-window-bounds
Open

binaricat wants to merge 2 commits into
mainfrom
fix/4106-small-window-bounds

Conversation

@binaricat

Copy link
Copy Markdown
Owner

Summary

Related to #4106.

  • Lower the nominal main-window minimum to 960×540 and fit oversized startup/restored bounds to the target display work area in DIPs. Preserve ordinary default dimensions, usable saved bounds, maximized/fullscreen behavior and display recovery.
  • Keep remembered wide vault editors within the available main-window surface without overwriting the user's preferred widths. At 960px, a desired 320/720 sidebar/editor renders as 320/378; growing to 1400px restores the desired 320/720.
  • Base explicit resize drags on the rendered edge. Clicking/cancelling a resize or unmounting does not inadvertently persist a viewport-imposed clamp. No hidden panes, navigation redesign or default styling changes.

Verification

  • 512 selected affected tests pass, with no failures or skips. The final six storage/resize regressions fail four cases against the pre-followup source and pass after the fix.
  • Lint and production build pass. Independent Codex review of the final tip against the recorded base found no actionable regressions.
  • Built Linux Electron on a 1093×585 Xvfb/Openbox work area: 960×540 and 983×526 main windows, each with default 208/420 and remembered 320/720 panel sizes. Navigation, fully reachable editor close/Save controls, save/edit/cancel, keyboard close/focus, a real terminal command, restart and preserved preferences pass.
  • Real pointer dragging, shrink/grow restoration, handle-click preference preservation, explicit narrower preferences and unmount/remount were exercised. Final source and build fingerprints match the committed tip.

Limitations

  • This fixes the main window, not the separate Settings window. Settings still measures 980×600 on the 1093×585 work area and exceeds its height by 15px.
  • Native Windows/macOS and physical fractional-DPI displays have not been verified. Existing narrow-toolbar text truncation is not a claim of complete application responsiveness.
  • Full test suite not run. Global typecheck retains the same 778 baseline diagnostics; this is not a clean global typecheck claim.

Recorded review base: 2368fc8232d7ce5c05352180faa838591d887854.
Final verified tip: 124cc3ad9c9a8da2982896db7a575548e7998d6e.

Please keep #4106 open for review and any remaining scope; this PR does not auto-close it.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T13:06:35.766124Z 124cc3a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant