Style ALL the selects#152
Open
geoffrey-eisenbarth wants to merge 5 commits intobigskysoftware:devfrom
Open
Conversation
Collaborator
Author
|
This will also close #134 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This untangles the web of
select[multiple][size]andappearance: base-select. Tested in Firefox and Chrome Canary, I'm pretty happy with it and would consider it appropriate to close #91 after this gets merged.I think
<select size|multiple>should be styled similar to the upcoming listbox component. To that end, one thing that I'm a little iffy on is whatoption:checked:not(:hover, :focus-visible)should look like. I copped the current styling from the old listbox impl, and it looks good when<select>is being used as a "native listbox." However, that style does (currently) bleed over to the dropdown picker (whenappearance: base-selectis supported, e.g. Chrome), and from what I can tell most UI impls of the dropdown picker have no styles onoption:checkedwhen it's not hovered/focused.This also inherently fixes some bugs in 1.2.0:
<select multiple>had a fixed height of lineheight+padding, resulting in broken listboxselect optionhadborder: inherit, which resulted in an ugly listbox.Thoughts?